[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 12/15] kvm: Support KVM_CLEAR_DIRTY_LOG
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2 12/15] kvm: Support KVM_CLEAR_DIRTY_LOG |
Date: |
Mon, 20 May 2019 12:50:24 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 20/05/19 05:08, Peter Xu wrote:
> + s->manual_dirty_log_protect =
> + kvm_check_extension(s, KVM_CAP_MANUAL_DIRTY_LOG_PROTECT2);
> + if (s->manual_dirty_log_protect) {
> + ret = kvm_vm_enable_cap(s, KVM_CAP_MANUAL_DIRTY_LOG_PROTECT2, 0, 1);
> + if (ret) {
> + warn_report("Trying to enable KVM_CAP_MANUAL_DIRTY_LOG_PROTECT "
Please use KVM_CAP_MANUAL_DIRTY_LOG_PROTECT2 in the error too (and in
the commit message).
Paolo
> + "but failed. Falling back to the legacy mode. ");
> + s->manual_dirty_log_protect = false;
> + }
- [Qemu-devel] [PATCH v2 02/15] linux-headers: Update to Linux 5.2-rc1, (continued)
- [Qemu-devel] [PATCH v2 02/15] linux-headers: Update to Linux 5.2-rc1, Peter Xu, 2019/05/19
- [Qemu-devel] [PATCH v2 06/15] bitmap: Add bitmap_copy_with_{src|dst}_offset(), Peter Xu, 2019/05/19
- [Qemu-devel] [PATCH v2 07/15] memory: Pass mr into snapshot_and_clear_dirty, Peter Xu, 2019/05/19
- [Qemu-devel] [PATCH v2 09/15] kvm: Update comments for sync_dirty_bitmap, Peter Xu, 2019/05/19
- [Qemu-devel] [PATCH v2 08/15] memory: Introduce memory listener hook log_clear(), Peter Xu, 2019/05/19
- [Qemu-devel] [PATCH v2 10/15] kvm: Persistent per kvmslot dirty bitmap, Peter Xu, 2019/05/19
- [Qemu-devel] [PATCH v2 11/15] kvm: Introduce slots lock for memory listener, Peter Xu, 2019/05/19
- [Qemu-devel] [PATCH v2 12/15] kvm: Support KVM_CLEAR_DIRTY_LOG, Peter Xu, 2019/05/19
- Re: [Qemu-devel] [PATCH v2 12/15] kvm: Support KVM_CLEAR_DIRTY_LOG,
Paolo Bonzini <=
- [Qemu-devel] [PATCH v2 13/15] qmp: Expose manual_dirty_log_protect via "query-kvm", Peter Xu, 2019/05/19
- [Qemu-devel] [PATCH v2 14/15] hmp: Expose manual_dirty_log_protect via "info kvm", Peter Xu, 2019/05/19
- [Qemu-devel] [PATCH v2 15/15] migration: Split log_clear() into smaller chunks, Peter Xu, 2019/05/19