[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/8] target/sparc: Define an enumeration for
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/8] target/sparc: Define an enumeration for accessing env->regwptr |
Date: |
Sun, 19 May 2019 20:09:45 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 5/14/19 10:44 PM, Philippe Mathieu-Daudé wrote:
>> +/* Windowed register indexes. */
>> +enum {
>> + WREG_O0,
>> + WREG_O1,
>> + WREG_O2,
>> + WREG_O3,
>> + WREG_O4,
>> + WREG_O5,
>> + WREG_O6,
>> + WREG_O7,
>> +
>> + WREG_L0,
>> + WREG_L1,
>> + WREG_L2,
>> + WREG_L3,
>> + WREG_L4,
>> + WREG_L5,
>> + WREG_L6,
>> + WREG_L7,
>> +
>> + WREG_I0,
>> + WREG_I1,
>> + WREG_I2,
>> + WREG_I3,
>> + WREG_I4,
>> + WREG_I5,
>> + WREG_I6,
>> + WREG_I7,
>
> I'd feel safer if you initialize those enums (better safe than sorry!).
What are you suggesting? This is how C works, and always has...
r~
- [Qemu-devel] [PATCH v2 0/8] linux-user sparc fixes, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v2 1/8] linux-user: Disallow setting newsp for fork, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v2 2/8] linux-user: Pass the parent env to cpu_clone_regs, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v2 4/8] linux-user/sparc: Use WREG constants in sparc/target_cpu.h, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v2 3/8] target/sparc: Define an enumeration for accessing env->regwptr, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v2 6/8] linux-user/sparc: Fix cpu_clone_regs, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v2 5/8] linux-user/sparc: Use WREG constants in sparc/signal.c, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v2 8/8] scripts/qemu-binfmt-conf: Update for sparc64, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v2 7/8] linux-user/sparc: Flush register windows before clone, Richard Henderson, 2019/05/09