Re: [Qemu-devel] [PATCH v2 00/16] hw: Use object_initialize_child for correct reference counting

[Philippe Mathieu-Daudé]

Hi Eduardo,

On 5/7/19 6:34 PM, Philippe Mathieu-Daudé wrote:
> Hi,
> 
> This series looks at Eduardo suggestions from [1]
> and Thomas commit aff39be0ed97 to replace various
> object_initialize + qdev_set_parent_bus calls by
> sysbus_init_child_obj().

Do you think you can take this series?
Else, via which tree it should go?

Thanks!

Phil.

> 
> Important comment from Eduardo:
> 
>   It's possible, but we need a volunteer to review each
>   hunk because the existing code might be (correctly)
>   calling object_unref() (either immediately or when
>   parent is finalized).
> 
> I tried to split it enough to make the review process
> easier.
> 
> Regards,
> 
> Phil.
> 
> [*] https://patchwork.ozlabs.org/patch/943333/#1953608
> v1: https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg05931.html
> 
> Philippe Mathieu-Daudé (16):
>   hw/ppc/pnv: Use object_initialize_child for correct reference counting
>   hw/misc/macio: Use object_initialize_child for correct ref. counting
>   hw/virtio: Use object_initialize_child for correct reference counting
>   hw/arm/bcm2835: Use TYPE_PL011 instead of hardcoded string
>   hw/arm/bcm2835: Use object_initialize() on PL011State
>   hw/arm/bcm2835: Use object_initialize_child for correct ref. counting
>   hw/arm/aspeed: Use object_initialize_child for correct ref. counting
>   hw/arm: Use object_initialize_child for correct reference counting
>   hw/mips: Use object_initialize() on MIPSCPSState
>   hw/mips: Use object_initialize_child for correct reference counting
>   hw/microblaze/zynqmp: Move the IPI state into the PMUSoC state
>   hw/microblaze/zynqmp: Let the SoC manage the IPI devices
>   hw/microblaze/zynqmp: Use object_initialize_child for correct ref.
>     counting
>   hw/microblaze/zynqmp: Use object_initialize_child for correct ref.
>     counting
>   hw/arm/mps2: Use object_initialize_child for correct reference
>     counting
>   hw/intc/nvic: Use object_initialize_child for correct reference
>     counting