[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH 0/4] iotests: Selfish patches

From: Max Reitz
Subject: [Qemu-devel] [PATCH 0/4] iotests: Selfish patches
Date: Fri, 17 May 2019 11:56:24 +0200


These are some rather selfish iotests patches.  The first patch helps me
personally because I tend to run the tests over SSH and forget to set
$DISPLAY.  That makes test 139 skip the tests annotated with
skip_if_unsupprted(), because iotests.py can no longer determine the
list of whitelisted formats.

Patch 2 through 4 are specifically for RHEL.  We have not whitelisted
null-aio, so it would be nice if tests didn’t require it.  Sorry, I
don’t have a better reason to give.
In all seriousness, null-co is used widely in many tests, it basically
is our standard null driver.  Tests should prefer it over null-aio, just
for consistency alone.  It is not completely unreasonable to treat
null-aio as optional.  I guess.

Final note: The best thing would probably to skip the null-aio tests in
093/136 if there is no null-aio support.  However, I didn’t get anything
to work: Annotating with @iotests.skip_if_unsupported() didn’t work
because the format name is a class instance attribute; and just
iotests.skipTest() didn’t work because that would print 's' characters
instead of '.' in the output (and emit the number of skipped tests), so
the comparison against the reference output fails...  Which is why I
decided to just run the test with null-co then.  That means that some
tests run twice with null-co (if there is no null-aio support), but
that’s not too bad.  Just ugly.

Max Reitz (4):
  iotests: Add -display none to the qemu options
  iotests: Prefer null-co over null-aio
  iotests: Test driver whitelisting in 093
  iotests: Test driver whitelisting in 136

 tests/qemu-iotests/093   | 22 +++++++++++++++-------
 tests/qemu-iotests/136   | 17 +++++++++++++----
 tests/qemu-iotests/245   |  2 +-
 tests/qemu-iotests/check |  2 +-
 4 files changed, 30 insertions(+), 13 deletions(-)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]