[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 2/6] qmp: make "qom-list-properties" show initial
From: |
Igor Mammedov |
Subject: |
[Qemu-devel] [PATCH v3 2/6] qmp: make "qom-list-properties" show initial property values |
Date: |
Fri, 17 May 2019 09:45:15 +0200 |
Add in the command output object's property values right after creation
(i.e. state of the object returned by object_new() or equivalent).
Follow up patch will add machine property 'numa-mem-supported', which
would allow mgmt to introspect which machine types (versions) still
support legacy "-numa mem=FOO" CLI option and which don't and require
alternative '-numa memdev' option being used.
Signed-off-by: Igor Mammedov <address@hidden>
---
qapi/misc.json | 5 ++++-
qmp.c | 5 +++++
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/qapi/misc.json b/qapi/misc.json
index 8b3ca4f..e333285 100644
--- a/qapi/misc.json
+++ b/qapi/misc.json
@@ -1365,10 +1365,13 @@
#
# @description: if specified, the description of the property.
#
+# @default: initial property value.
+#
# Since: 1.2
##
{ 'struct': 'ObjectPropertyInfo',
- 'data': { 'name': 'str', 'type': 'str', '*description': 'str' } }
+ 'data': { 'name': 'str', 'type': 'str', '*description': 'str',
+ '*default': 'any' } }
##
# @qom-list:
diff --git a/qmp.c b/qmp.c
index b92d62c..8415541 100644
--- a/qmp.c
+++ b/qmp.c
@@ -593,6 +593,11 @@ ObjectPropertyInfoList *qmp_qom_list_properties(const char
*typename,
info->type = g_strdup(prop->type);
info->has_description = !!prop->description;
info->description = g_strdup(prop->description);
+ if (obj) {
+ info->q_default =
+ object_property_get_qobject(obj, info->name, NULL);
+ info->has_q_default = !!info->q_default;
+ }
entry = g_malloc0(sizeof(*entry));
entry->value = info;
--
2.7.4
- [Qemu-devel] [PATCH v3 0/6] numa: deprecate '-numa node, mem' and default memory distribution, Igor Mammedov, 2019/05/17
- [Qemu-devel] [PATCH v3 1/6] pc: fix possible NULL pointer dereference in pc_machine_get_device_memory_region_size(), Igor Mammedov, 2019/05/17
- [Qemu-devel] [PATCH v3 2/6] qmp: make "qom-list-properties" show initial property values,
Igor Mammedov <=
- [Qemu-devel] [PATCH v3 3/6] qmp: qmp_qom_list_properties(): ignore empty string options, Igor Mammedov, 2019/05/17
- [Qemu-devel] [PATCH v3 4/6] numa: introduce "numa-mem-supported" machine property, Igor Mammedov, 2019/05/17
- [Qemu-devel] [PATCH v3 5/6] numa: deprecate 'mem' parameter of '-numa node' option, Igor Mammedov, 2019/05/17
- [Qemu-devel] [PATCH v3 6/6] numa: deprecate implict memory distribution between nodes, Igor Mammedov, 2019/05/17