[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL 02/21] roms: assert if max rom size is less than

From: Thomas Huth
Subject: Re: [Qemu-devel] [PULL 02/21] roms: assert if max rom size is less than the used size
Date: Thu, 16 May 2019 14:40:26 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1

On 15/05/2019 22.50, Paolo Bonzini wrote:
> From: Igor Mammedov <address@hidden>
> It would ensure that we would notice attempt to write beyond
> the allocated buffer. In case of MemoryRegion backed ROM it's
> the host buffer and the guest RAM otherwise.
> assert can be triggered with:
>   dd if=/dev/zero of=/tmp/blob bs=63k count=1
>   qemu-system-x86_64 `for  i in {1..33}; do echo -n " -acpitable /tmp/blob"; 
> done`

Sorry, but a user should normally never be able to trigger an assert,
even if passing lots of garbage to qemu via the command line. asserts
are for guarding against programming errors.

Could you please change this into a proper error message instead?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]