[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 6/6] acpi: pci: use build_append_foo() API to
Re: [Qemu-devel] [PATCH v4 6/6] acpi: pci: use build_append_foo() API to construct MCFG
Thu, 16 May 2019 13:01:31 +0200
On Thu, May 16, 2019 at 9:41 AM Wei Yang <address@hidden> wrote:
> On Wed, May 15, 2019 at 07:29:17AM +0200, Philippe Mathieu-Daudé wrote:
> >Thanks Michael for testing...
> >Wei, can you add a MCFG test in tests/bios-tables-test.c?
> I took a look into the test, current q35 has already has a reference MCFG in
> And there would be a warning message when reserved is missed.
> /x86_64/acpi/q35/bridge: acpi-test: Warning! MCFG mismatch.
> Is this enough? Or what more information prefer to add?
Well, the test has to fail for any mismatch (not a simple warning).
A mismatch failure seems to be enough IMHO.
> >>> - AcpiMcfgAllocation allocation;
> >>> -} QEMU_PACKED;
> >>> -typedef struct AcpiTableMcfg AcpiTableMcfg;
> >>> -
> >>> /*
> >>> * TCPA Description Table
> >>> *
> >>> --
> >>> 2.19.1
> Wei Yang
> Help you, Help me
Re: [Qemu-devel] [PATCH v4 6/6] acpi: pci: use build_append_foo() API to construct MCFG, Wei Yang, 2019/05/15