[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 22/27] gdbstub: Implement generic query qemu.
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH v9 22/27] gdbstub: Implement generic query qemu.Supported |
Date: |
Wed, 15 May 2019 18:41:57 +0100 |
User-agent: |
mu4e 1.3.1; emacs 26.1 |
Jon Doron <address@hidden> writes:
> qemu.Supported query reply back with the supported qemu query/set
> commands (commands are seperated with a semicolon from each other).
>
> gdb> maint packet qqemu.Supported
>
> Signed-off-by: Jon Doron <address@hidden>
> ---
> gdbstub.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/gdbstub.c b/gdbstub.c
> index 8bdfae4b29..00c07d6ec0 100644
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -2127,6 +2127,11 @@ static void handle_query_attached(GdbCmdContext
> *gdb_ctx, void *user_ctx)
> put_packet(gdb_ctx->s, GDB_ATTACHED);
> }
>
> +static void handle_query_qemu_supported(GdbCmdContext *gdb_ctx, void
> *user_ctx)
> +{
> + put_packet(gdb_ctx->s, "sstepbits;sstep");
To maintain bisectability this response should be extended as each
feature is added.
> +}
> +
> static GdbCmdParseEntry gdb_gen_query_set_common_table[] = {
> /* Order is important if has same prefix */
> {
> @@ -2203,6 +2208,10 @@ static GdbCmdParseEntry gdb_gen_query_table[] = {
> .handler = handle_query_attached,
> .cmd = "Attached",
> },
> + {
> + .handler = handle_query_qemu_supported,
> + .cmd = "qemu.Supported",
> + },
> };
>
> static void handle_gen_query(GdbCmdContext *gdb_ctx, void *user_ctx)
--
Alex Bennée
- [Qemu-devel] [PATCH v9 10/27] gdbstub: Implement get register (p pkt) with new infra, (continued)
- [Qemu-devel] [PATCH v9 10/27] gdbstub: Implement get register (p pkt) with new infra, Jon Doron, 2019/05/02
- [Qemu-devel] [PATCH v9 09/27] gdbstub: Implement set register (P pkt) with new infra, Jon Doron, 2019/05/02
- [Qemu-devel] [PATCH v9 17/27] gdbstub: Implement v commands with new infra, Jon Doron, 2019/05/02
- [Qemu-devel] [PATCH v9 06/27] gdbstub: Implement set_thread (H pkt) with new infra, Jon Doron, 2019/05/02
- [Qemu-devel] [PATCH v9 22/27] gdbstub: Implement generic query qemu.Supported, Jon Doron, 2019/05/02
- Re: [Qemu-devel] [PATCH v9 22/27] gdbstub: Implement generic query qemu.Supported,
Alex Bennée <=
- [Qemu-devel] [PATCH v9 07/27] gdbstub: Implement insert breakpoint (Z pkt) with new infra, Jon Doron, 2019/05/02
- [Qemu-devel] [PATCH v9 20/27] gdbstub: Implement target halted (? pkt) with new infra, Jon Doron, 2019/05/02
- [Qemu-devel] [PATCH v9 12/27] gdbstub: Implement read memory (m pkt) with new infra, Jon Doron, 2019/05/02
- [Qemu-devel] [PATCH v9 16/27] gdbstub: Implement step (s pkt) with new infra, Jon Doron, 2019/05/02