[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 3/4] virtio-rng: Keep the default backend out

From: Laurent Vivier
Subject: Re: [Qemu-devel] [PATCH v5 3/4] virtio-rng: Keep the default backend out of VirtIORNGConf
Date: Tue, 14 May 2019 18:53:08 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0

On 14/05/2019 18:27, Laurent Vivier wrote:
From: Markus Armbruster <address@hidden>

The default backend is only used within virtio_rng_device_realize().
Replace VirtIORNGConf member default_backend by a local variable.
Adjust its type to reduce conversions.

While there, pass &error_abort instead of NULL when failure would be a
programming error.

Signed-off-by: Markus Armbruster <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
  hw/virtio/virtio-rng.c         | 20 +++++++++-----------
  include/hw/virtio/virtio-rng.h |  2 --
  2 files changed, 9 insertions(+), 13 deletions(-)

diff --git a/hw/virtio/virtio-rng.c b/hw/virtio/virtio-rng.c
index 30493a258622..73ffb476e030 100644
--- a/hw/virtio/virtio-rng.c
+++ b/hw/virtio/virtio-rng.c
@@ -16,6 +16,7 @@
  #include "hw/virtio/virtio.h"
  #include "hw/virtio/virtio-rng.h"
  #include "sysemu/rng.h"
+#include "sysemu/rng-random.h"

I forgot to remove this line in PATCH 4... I will in v6...


reply via email to

[Prev in Thread] Current Thread [Next in Thread]