[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 00/25] Add qemu_getrandom and ARMv8.5-RNG etc
From: |
Daniel P . Berrangé |
Subject: |
Re: [Qemu-devel] [PATCH v6 00/25] Add qemu_getrandom and ARMv8.5-RNG etc |
Date: |
Tue, 14 May 2019 16:23:31 +0100 |
User-agent: |
Mutt/1.11.4 (2019-03-13) |
On Tue, May 14, 2019 at 05:15:31PM +0200, Markus Armbruster wrote:
> "make check-unit" fails for me:
>
> TEST check-unit: tests/test-crypto-tlscredsx509
> Unexpected error in object_new_with_propv() at
> /work/armbru/qemu/qom/object.c:674:
> invalid object type: tls-creds-x509
>
> and
>
> TEST check-unit: tests/test-io-channel-tls
> Unexpected error in object_new_with_propv() at
> /work/armbru/qemu/qom/object.c:674:
> invalid object type: tls-creds-x509
>
> I haven't looked further.
I have a nasty feeling it is caused by
Subject: [PATCH v6 02/25] crypto: Merge crypto-obj-y into libqemuutil.a
The QOM objects are not directly used by most of the code. We rely on
the constructor registering the QOM object and then we request an
instance of it via the type name. So there's no direct function calls
from any code into the crypto object impls.
When we put the crypto objects into libqemuutil.a the linker is not
intelligent enough to see the constructor and so thinks all these
QOM object impls are unused and discards them when linking the final
binary.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [Qemu-devel] [PATCH v6 20/25] hw/misc/exynos4210_rng: Use qemu_guest_getrandom, (continued)
- [Qemu-devel] [PATCH v6 20/25] hw/misc/exynos4210_rng: Use qemu_guest_getrandom, Richard Henderson, 2019/05/10
- [Qemu-devel] [PATCH v6 22/25] target/arm: Implement ARMv8.5-RNG, Richard Henderson, 2019/05/10
- [Qemu-devel] [PATCH v6 23/25] target/ppc: Use qemu_guest_getrandom for DARN, Richard Henderson, 2019/05/10
- [Qemu-devel] [PATCH v6 21/25] target/arm: Put all PAC keys into a structure, Richard Henderson, 2019/05/10
- [Qemu-devel] [PATCH v6 25/25] target/i386: Implement CPUID_EXT_RDRAND, Richard Henderson, 2019/05/10
- [Qemu-devel] [PATCH v6 24/25] target/ppc: Use gen_io_start/end around DARN, Richard Henderson, 2019/05/10
- Re: [Qemu-devel] [PATCH v6 00/25] Add qemu_getrandom and ARMv8.5-RNG etc, Markus Armbruster, 2019/05/14
- Re: [Qemu-devel] [PATCH v6 00/25] Add qemu_getrandom and ARMv8.5-RNG etc,
Daniel P . Berrangé <=
- Re: [Qemu-devel] [PATCH v6 00/25] Add qemu_getrandom and ARMv8.5-RNG etc, Richard Henderson, 2019/05/14
- Re: [Qemu-devel] [PATCH v6 00/25] Add qemu_getrandom and ARMv8.5-RNG etc, Daniel P . Berrangé, 2019/05/14
- Re: [Qemu-devel] [PATCH v6 00/25] Add qemu_getrandom and ARMv8.5-RNG etc, Richard Henderson, 2019/05/14
- Re: [Qemu-devel] [PATCH v6 00/25] Add qemu_getrandom and ARMv8.5-RNG etc, Eric Blake, 2019/05/14
- Re: [Qemu-devel] [PATCH v6 00/25] Add qemu_getrandom and ARMv8.5-RNG etc, Richard Henderson, 2019/05/14