Re: [Qemu-devel] [PATCH v7 1/8] vhost-user: add vhost_user_gpu_set_socket()

[Gerd Hoffmann]

> > > +  typedef struct VhostUserGpuMsg {
> > > +      uint32_t request; /* VhostUserGpuRequest */
> > > +      uint32_t flags;
> > > +      uint32_t size; /* the following payload size */
> >
> > uint32_t padding;
> >
> > > +      union {
> > > +          VhostUserGpuCursorPos cursor_pos;
> > > +          VhostUserGpuCursorUpdate cursor_update;
> > > +          VhostUserGpuScanout scanout;
> > > +          VhostUserGpuUpdate update;
> > > +          VhostUserGpuDMABUFScanout dmabuf_scanout;
> > > +          struct virtio_gpu_resp_display_info display_info;
> > > +          uint64_t u64;
> >
> > ... so this 64bit value will be aligned.
> 
> vhost-user didn't bother. Should we?

I think it is nicer, but given that the struct is declared as "packed"
it'll work either way.

Matter of taste.  Consider it a suggestion.

cheers,
  Gerd