[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] nbd/server: Nicer spelling of max BLOCK_STATUS
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH] nbd/server: Nicer spelling of max BLOCK_STATUS reply length |
Date: |
Mon, 13 May 2019 09:31:33 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 5/13/19 5:03 AM, Vladimir Sementsov-Ogievskiy wrote:
> 10.05.2019 18:17, Eric Blake wrote:
>> Commit 3d068aff (3.0) introduced NBD_MAX_BITMAP_EXTENTS as a limit on
>> how large we would allow a reply to NBD_CMD_BLOCK_STATUS to grow when
>> it is visiting a qemu:dirty-bitmap: context. Later, commit fb7afc79
>> (3.1) reused the constant to limit base:allocation context replies,
>> although the name is now less appropriate in that situation.
>>
>> Rename things, and improve the macro to use units.h for better
>> legibility. Then reformat the comment to comply with checkpatch rules
>> added in the meantime. No semantic change.
>>
>> Signed-off-by: Eric Blake <address@hidden>
>
>
> With or without Stefano's suggestion:
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
I'm assuming Reviewed-by instead of Signed-off-by?
I'll queue this through my NBD tree, with Stefano's suggestion added in.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature