[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 22/24] target/arm: Implement ARMv8.5-RNG
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v5 22/24] target/arm: Implement ARMv8.5-RNG |
Date: |
Fri, 10 May 2019 17:01:03 +0100 |
On Fri, 10 May 2019 at 02:25, Richard Henderson
<address@hidden> wrote:
>
> Cc: address@hidden
> Cc: Peter Maydell <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> v3: Log errors with -d unimp, for lack of a better flag.
> ---
> target/arm/cpu.h | 5 +++++
> target/arm/cpu64.c | 1 +
> target/arm/helper.c | 44 ++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 50 insertions(+)
> +/* We do not support re-seeding, so the two registers operate the same. */
> +static const ARMCPRegInfo rndr_reginfo[] = {
> + { .name = "RNDR", .state = ARM_CP_STATE_AA64,
> + .type = ARM_CP_NO_RAW | ARM_CP_SUPPRESS_TB_END,
> + .opc0 = 3, .opc1 = 3, .crn = 2, .crm = 4, .opc2 = 0,
> + .access = PL0_R, .readfn = rndr_readfn },
> + { .name = "RNDRRS", .state = ARM_CP_STATE_AA64,
> + .type = ARM_CP_NO_RAW | ARM_CP_SUPPRESS_TB_END,
> + .opc0 = 3, .opc1 = 3, .crn = 2, .crm = 4, .opc2 = 1,
> + .access = PL0_R, .readfn = rndr_readfn },
Don't these need to be marked ARM_CP_IO for the benefit
of -icount ?
Otherwise
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
- [Qemu-devel] [PATCH v5 08/24] ui/vnc: Split out authentication_failed, (continued)
- [Qemu-devel] [PATCH v5 08/24] ui/vnc: Split out authentication_failed, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v5 10/24] util: Add qemu_guest_getrandom and associated routines, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v5 15/24] linux-user/aarch64: Use qemu_guest_getrandom for PAUTH keys, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v5 16/24] linux-user: Remove srand call, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v5 17/24] aspeed/scu: Use qemu_guest_getrandom_nofail, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v5 20/24] hw/misc/exynos4210_rng: Use qemu_guest_getrandom, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v5 19/24] hw/misc/bcm2835_rng: Use qemu_guest_getrandom_nofail, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v5 21/24] target/arm: Put all PAC keys into a structure, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v5 22/24] target/arm: Implement ARMv8.5-RNG, Richard Henderson, 2019/05/09
- Re: [Qemu-devel] [PATCH v5 22/24] target/arm: Implement ARMv8.5-RNG,
Peter Maydell <=
[Qemu-devel] [PATCH v5 23/24] target/ppc: Use qemu_guest_getrandom for DARN, Richard Henderson, 2019/05/09
[Qemu-devel] [PATCH v5 24/24] target/i386: Implement CPUID_EXT_RDRAND, Richard Henderson, 2019/05/09