Re: [Qemu-devel] [PATCH v2 14/27] target/nios2: Convert to CPUClass::tlb_fill

[Richard Henderson]

On 5/9/19 3:02 AM, Peter Maydell wrote:
> On Thu, 9 May 2019 at 07:10, Richard Henderson
> <address@hidden> wrote:
>>
>> Remove the leftover debugging cpu_dump_state.
>>
>> Cc: Chris Wulff <address@hidden>
>> Cc: Marek Vasut <address@hidden>
>> Signed-off-by: Richard Henderson <address@hidden>
>> ---
>> v2: Keep user-only and system tlb_fill separate.
>> ---
> 
>> -int nios2_cpu_handle_mmu_fault(CPUState *cs, vaddr address, int size,
>> -                               int rw, int mmu_idx)
>> +bool nios2_cpu_tlb_fill(CPUState *cs, vaddr address, int size,
>> +                        MMUAccessType access_type, int mmu_idx,
>> +                        bool probe, uintptr_t retaddr)
>>  {
>>      cs->exception_index = 0xaa;
>>      /* Page 0x1000 is kuser helper */
>>      if (address < 0x1000 || address >= 0x2000) {
>>          cpu_dump_state(cs, stderr, 0);
>>      }
>> -    return 1;
>> +    cpu_loop_exit_restore(cs, retaddr);
>>  }
> 
> Commit message says we delete cpu_dump_state() call but
> the code doesn't seem to change it?
> 
> Otherwise
> Reviewed-by: Peter Maydell <address@hidden>

Argh.  Got lost in the other v2 changes.


r~