[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/13] tests/vm: send locale environment variabl
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH 03/13] tests/vm: send locale environment variables over ssh |
Date: |
Thu, 9 May 2019 09:35:11 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 08/05/2019 10.56, Gerd Hoffmann wrote:
> Needed for unicode tests.
>
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
> tests/vm/basevm.py | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py
> index 6b46674f4497..20eec5420dbf 100755
> --- a/tests/vm/basevm.py
> +++ b/tests/vm/basevm.py
> @@ -43,6 +43,20 @@ class BaseVM(object):
> "http_proxy",
> "ftp_proxy",
> "no_proxy",
> + "LANG",
> + "LC_CTYPE",
> + "LC_NUMERIC",
> + "LC_TIME",
> + "LC_COLLATE",
> + "LC_MONETARY",
> + "LC_MESSAGES",
> + "LC_PAPER",
> + "LC_NAME",
> + "LC_ADDRESS",
> + "LC_TELEPHONE",
> + "LC_MEASUREMENT",
> + "LC_IDENTIFICATION",
> + "LC_ALL",
> ]
I gave your patch series a try, but now I see a lot of these messages in
the output:
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
LC_ALL = (unset),
LC_TIME = "en_DK.UTF-8",
LANG = "en_DK.UTF-8"
are supported and installed on your system.
Is it really a good idea to use the host locale in the guest, too? ... I
don't think so... at least you should make sure that *all* possible
locales are installed in that case.
"gmake check" then also finally failed:
--- /home/qemu/qemu-test.AOvcgx/src/tests/qapi-schema/unicode-str.err
2019-05-09 05:56:17.000000000 +0000
+++ - 2019-05-09 06:12:54.451392000 +0000
@@ -1 +1 @@
-tests/qapi-schema/unicode-str.json:2: 'command' uses invalid name 'é'
+tests/qapi-schema/unicode-str.json:2: 'command' uses invalid name '\xe9'
Note that if you just wanted to fix the python3 utf-8 problem with this
patch here, there is a separate fix available for that problem already:
https://lists.gnu.org/archive/html/qemu-devel/2019-05/msg01247.html
HTH,
Thomas
- [Qemu-devel] [PATCH 00/13] tests/vm: serial console autoinstall, misc fixes., Gerd Hoffmann, 2019/05/08
- [Qemu-devel] [PATCH 03/13] tests/vm: send locale environment variables over ssh, Gerd Hoffmann, 2019/05/08
- Re: [Qemu-devel] [PATCH 03/13] tests/vm: send locale environment variables over ssh,
Thomas Huth <=
- [Qemu-devel] [PATCH 04/13] tests/vm: use ssh with pty unconditionally, Gerd Hoffmann, 2019/05/08
- [Qemu-devel] [PATCH 02/13] tests/vm: send proxy environment variables over ssh, Gerd Hoffmann, 2019/05/08
- [Qemu-devel] [PATCH 01/13] scripts: use git archive in archive-source, Gerd Hoffmann, 2019/05/08
- [Qemu-devel] [PATCH 07/13] tests/vm: add DEBUG=1 to help text, Gerd Hoffmann, 2019/05/08
- [Qemu-devel] [PATCH 12/13] tests/vm: fedora autoinstall, using serial console, Gerd Hoffmann, 2019/05/08
- [Qemu-devel] [PATCH 13/13] tests/vm: ubuntu.i386: apt proxy setup, Gerd Hoffmann, 2019/05/08