Re: [Qemu-devel] [PATCH] The ioctl(SIOCGIFNAME) call requires a struct ifreq.

[Erik Kline]

Anything else I need to do?

On Wed, 24 Apr 2019 at 02:10, Peter Maydell <address@hidden>
wrote:

> On Tue, 23 Apr 2019 at 23:28, Erik Kline via Qemu-devel
> <address@hidden> wrote:
> >
> > Signed-off-by: Erik Kline <address@hidden>
> > Buglink: https://bugs.launchpad.net/qemu/+bug/1814352
> > ---
> >  linux-user/ioctls.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/linux-user/ioctls.h b/linux-user/ioctls.h
> > index ae8951625f..37501f575c 100644
> > --- a/linux-user/ioctls.h
> > +++ b/linux-user/ioctls.h
> > @@ -178,7 +178,7 @@
> >  #endif /* CONFIG_USBFS */
> >
> >    IOCTL(SIOCATMARK, IOC_R, MK_PTR(TYPE_INT))
> > -  IOCTL(SIOCGIFNAME, IOC_RW, MK_PTR(TYPE_INT))
> > +  IOCTL(SIOCGIFNAME, IOC_RW, MK_PTR(MK_STRUCT(STRUCT_int_ifreq)))
> >    IOCTL(SIOCGIFFLAGS, IOC_W | IOC_R,
> MK_PTR(MK_STRUCT(STRUCT_short_ifreq)))
> >    IOCTL(SIOCSIFFLAGS, IOC_W, MK_PTR(MK_STRUCT(STRUCT_short_ifreq)))
> >    IOCTL(SIOCGIFADDR, IOC_W | IOC_R,
> MK_PTR(MK_STRUCT(STRUCT_sockaddr_ifreq)))
> > --
> > 2.21.0.593.g511ec345e18-goog
> >
>
> Reviewed-by: Peter Maydell <address@hidden>
>
> thanks
> -- PMM
>