[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 1/5] qemu-nbd: Add --pid-file option
From: |
Max Reitz |
Subject: |
[Qemu-devel] [PATCH v3 1/5] qemu-nbd: Add --pid-file option |
Date: |
Wed, 8 May 2019 23:18:16 +0200 |
--fork is a bit boring if there is no way to get the child's PID. This
option helps.
Signed-off-by: Max Reitz <address@hidden>
---
qemu-nbd.c | 11 +++++++++++
qemu-nbd.texi | 2 ++
2 files changed, 13 insertions(+)
diff --git a/qemu-nbd.c b/qemu-nbd.c
index dca9e72cee..edb5195208 100644
--- a/qemu-nbd.c
+++ b/qemu-nbd.c
@@ -59,6 +59,7 @@
#define QEMU_NBD_OPT_IMAGE_OPTS 262
#define QEMU_NBD_OPT_FORK 263
#define QEMU_NBD_OPT_TLSAUTHZ 264
+#define QEMU_NBD_OPT_PID_FILE 265
#define MBR_SIZE 512
@@ -111,6 +112,7 @@ static void usage(const char *name)
" specify tracing options\n"
" --fork fork off the server process and exit the parent\n"
" once the server is running\n"
+" --pid-file=PATH store the server's process ID in the given file\n"
#if HAVE_NBD_DEVICE
"\n"
"Kernel NBD client support:\n"
@@ -651,6 +653,7 @@ int main(int argc, char **argv)
{ "image-opts", no_argument, NULL, QEMU_NBD_OPT_IMAGE_OPTS },
{ "trace", required_argument, NULL, 'T' },
{ "fork", no_argument, NULL, QEMU_NBD_OPT_FORK },
+ { "pid-file", required_argument, NULL, QEMU_NBD_OPT_PID_FILE },
{ NULL, 0, NULL, 0 }
};
int ch;
@@ -677,6 +680,7 @@ int main(int argc, char **argv)
bool list = false;
int old_stderr = -1;
unsigned socket_activation;
+ const char *pid_file_name = NULL;
/* The client thread uses SIGTERM to interrupt the server. A signal
* handler ensures that "qemu-nbd -v -c" exits with a nice status code.
@@ -876,6 +880,9 @@ int main(int argc, char **argv)
case 'L':
list = true;
break;
+ case QEMU_NBD_OPT_PID_FILE:
+ pid_file_name = optarg;
+ break;
}
}
@@ -1196,6 +1203,10 @@ int main(int argc, char **argv)
nbd_update_server_watch();
+ if (pid_file_name) {
+ qemu_write_pidfile(pid_file_name, &error_fatal);
+ }
+
/* now when the initialization is (almost) complete, chdir("/")
* to free any busy filesystems */
if (chdir("/") < 0) {
diff --git a/qemu-nbd.texi b/qemu-nbd.texi
index de342c76b8..7f55657722 100644
--- a/qemu-nbd.texi
+++ b/qemu-nbd.texi
@@ -117,6 +117,8 @@ option; or provide the credentials needed for connecting as
a client
in list mode.
@item --fork
Fork off the server process and exit the parent once the server is running.
address@hidden --pid-file=PATH
+Store the server's process ID in the given file.
@item --tls-authz=ID
Specify the ID of a qauthz object previously created with the
--object option. This will be used to authorize connecting users
--
2.21.0
- [Qemu-devel] [PATCH v3 0/5] iotests: Let 233 run concurrently, Max Reitz, 2019/05/08
- [Qemu-devel] [PATCH v3 1/5] qemu-nbd: Add --pid-file option,
Max Reitz <=
- [Qemu-devel] [PATCH v3 2/5] iotests.py: Add qemu_nbd_early_pipe(), Max Reitz, 2019/05/08
- [Qemu-devel] [PATCH v3 3/5] qemu-nbd: Do not close stderr, Max Reitz, 2019/05/08
- [Qemu-devel] [PATCH v3 4/5] iotests: Use qemu-nbd's --pid-file, Max Reitz, 2019/05/08
- [Qemu-devel] [PATCH v3 5/5] iotests: Let 233 run concurrently, Max Reitz, 2019/05/08
- Re: [Qemu-devel] [PATCH v3 0/5] iotests: Let 233 run concurrently, Eric Blake, 2019/05/24