Re: [Qemu-devel] [PATCH v10 01/13] target/rx: TCG translation

[Richard Henderson]

On 5/8/19 7:55 AM, Yoshinori Sato wrote:
> +static bool trans_XCHG_mr(DisasContext *ctx, arg_XCHG_mr *a)
> +{
> +    TCGv mem, addr;
> +    mem = tcg_temp_new();
> +    switch (a->mi) {
> +    case 0: /* dsp[rs].b */
> +    case 1: /* dsp[rs].w */
> +    case 2: /* dsp[rs].l */
> +        addr = rx_index_addr(ctx, mem, a->ld, a->mi, a->rs);
> +        break;
> +    case 3: /* dsp[rs].uw */
> +    case 4: /* dsp[rs].ub */
> +        addr = rx_index_addr(ctx, mem, a->ld, 4 - a->mi, a->rs);
> +        break;
> +    }

You need

    default:
        g_assert_not_reached();

to avoid the compilation error pointed out by Phil.

Otherwise,
Reviewed-by: Richard Henderson <address@hidden>


r~