[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] tests: qpci_unplug_acpi_device_test() should no
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH] tests: qpci_unplug_acpi_device_test() should not rely on global_qtest |
|
Date: |
Wed, 8 May 2019 09:49:26 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 5/8/19 9:32 AM, Thomas Huth wrote:
> libqos functions should not use functions that require global_qtest to
> be set, since such library functions could also be used by tests that
> deal with multiple test states. Add a parameter to this function to
> explicitly specify the test state.
>
> Signed-off-by: Thomas Huth <address@hidden>
> ---
> tests/e1000e-test.c | 4 +++-
> tests/ivshmem-test.c | 9 ++++++---
> tests/libqos/pci-pc.c | 10 +++++-----
> tests/libqos/pci.h | 2 +-
> tests/virtio-blk-test.c | 3 ++-
> tests/virtio-net-test.c | 4 +++-
> tests/virtio-rng-test.c | 5 ++++-
> 7 files changed, 24 insertions(+), 13 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature