qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] qemu-iotests: Fix cleanup for 192


From: Thomas Huth
Subject: Re: [Qemu-devel] [PATCH] qemu-iotests: Fix cleanup for 192
Date: Wed, 8 May 2019 14:06:48 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1

On 08/05/2019 14.04, Kevin Wolf wrote:
> Test case 192 calls _launch_qemu, so it also needs to _cleanup_qemu when
> it's done, otherwise the QMP FIFOs stay around in scratch/. It also
> creates a temporary NBD socket that needs to be removed as well at the
> end of the test case.
> 
> Reported-by: Thomas Huth <address@hidden>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  tests/qemu-iotests/192 | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/qemu-iotests/192 b/tests/qemu-iotests/192
> index 158086f9d2..61a88ac88d 100755
> --- a/tests/qemu-iotests/192
> +++ b/tests/qemu-iotests/192
> @@ -29,7 +29,9 @@ status=1    # failure is the default!
>  
>  _cleanup()
>  {
> -     _cleanup_test_img
> +    _cleanup_qemu
> +    _cleanup_test_img
> +    rm -f "$TEST_DIR/nbd"
>  }
>  trap "_cleanup; exit \$status" 0 1 2 3 15

That fixes the issue, indeed! Thanks!

Tested-by: Thomas Huth <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]