Re: [Qemu-devel] [PATCH] iotests: Make 182 do without device_add

[Eric Blake]

On 5/7/19 8:21 AM, Max Reitz wrote:
> On 17.04.19 17:30, Max Reitz wrote:
>> 182 fails if qemu has no support for hotplugging of a virtio-blk device.
>> Using an NBD server instead works just as well for the test, even on
>> qemus without hotplugging support.
>>
>> Fixes: 6d0a4a0fb5c8f10c8eb68b52cfda0082b00ae963
>> Reported-by: Danilo C. L. de Paula <address@hidden>
>> Signed-off-by: Max Reitz <address@hidden>
>> ---
>> To reintroduce the bug for which this test was written, revert the
>> following commits:
>>
>> $ git revert -n \
>>     23dece19da41724349809873923e20a48b619cb7 \
>>     6ceabe6f77e4ae5ac2fa3d2ac1be11dc95021941 \
>>     a6aeca0ca530f104b5a5dd6704fca22b2c5edefa \
>>     577a133988c76e4ebf01d050d0d758d207a1baf7
>> ---
>>  tests/qemu-iotests/182     | 22 +++++++++++++++++-----
>>  tests/qemu-iotests/182.out |  1 +
>>  2 files changed, 18 insertions(+), 5 deletions(-)
> 
> Thanks for the reviews, applied to my block branch.

Hmm, just seeing this after I already sent a pull request doing the same
through NBD. Git should handle things correctly, whether or not you
rebase to drop patches from your block branch that get in through my NBD
pull request.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature