Re: [Qemu-devel] [PATCH 06/14] target/ppc: introduce GEN_VSX_HELPER_X2_AB macro to fpu_helper.c

[Mark Cave-Ayland]

On 30/04/2019 17:41, Richard Henderson wrote:

> On 4/28/19 7:38 AM, Mark Cave-Ayland wrote:
>> Rather than perform the VSR register decoding within the helper itself,
>> introduce a new GEN_VSX_HELPER_X2_AB macro which performs the decode based
>> upon xA and xB at translation time.
>>
>> Signed-off-by: Mark Cave-Ayland <address@hidden>
>> ---
>>  target/ppc/fpu_helper.c             | 15 ++++++---------
>>  target/ppc/helper.h                 | 12 ++++++------
>>  target/ppc/translate/vsx-impl.inc.c | 30 ++++++++++++++++++++++++------
>>  3 files changed, 36 insertions(+), 21 deletions(-)
> 
> This time I see VSX_TDIV right away as a place that still
> uses opcode.  It can certainly be cleaned up, but that's
> a different patch.

Right, and also helper_xscmpexpdp() and VSX_SCALAR_CMP() which is all of the 
helpers
touched here. Perhaps one to think about since if this macro isn't used 
anywhere else
after I've reworked the series to use separate gen/helper functions then 
probably it
makes sense not to bother with this one.


ATB,

Mark.