[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL 19/19] configure: automatically pick python3 is a

From: Thomas Huth
Subject: Re: [Qemu-devel] [PULL 19/19] configure: automatically pick python3 is available
Date: Fri, 3 May 2019 18:41:43 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1

On 03/05/2019 02.41, Eduardo Habkost wrote:
> From: Daniel P. Berrangé <address@hidden>
> Unless overridden via an env var or configure arg, QEMU will only look
> for the 'python' binary in $PATH. This is unhelpful on distros which
> are only shipping Python 3.x (eg Fedora) in their default install as,
> if they comply with PEP 394, the bare 'python' binary won't exist.
> This changes configure so that by default it will search for all three
> common python binaries, preferring to find Python 3.x versions.
> Signed-off-by: Daniel P. Berrangé <address@hidden>
> Message-Id: <address@hidden>
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
>  configure | 18 +++++++++++++++---
>  1 file changed, 15 insertions(+), 3 deletions(-)

I haven't bisected it, but I think this patch here broke the gitlab-ci tests:


Seems like the test is now failing when you don't have an UTF-8 locale:

 LANG=C make check-qapi-schema
 TEST    tests/qapi-schema/union-base-empty.out
 --- /builds/huth/qemu/tests/qapi-schema/unicode-str.err        2019-05-03 
15:21:39.000000000 +0000
 +++ -  2019-05-03 15:42:01.561762978 +0000
 @@ -1 +1 @@
 -tests/qapi-schema/unicode-str.json:2: 'command' uses invalid name 'é'
 +tests/qapi-schema/unicode-str.json:2: 'command' uses invalid name '\xe9'
 /builds/huth/qemu/tests/Makefile.include:1105: recipe for target 
'check-tests/qapi-schema/unicode-str.json' failed
 make: *** [check-tests/qapi-schema/unicode-str.json] Error 1

Any ideas how to fix this?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]