[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v2 09/12] net: Print output of "-net nic, model=help"
From: |
Laurent Vivier |
Subject: |
[Qemu-devel] [PULL v2 09/12] net: Print output of "-net nic, model=help" to stdout instead of stderr |
Date: |
Fri, 3 May 2019 13:26:51 +0200 |
From: Thomas Huth <address@hidden>
We are printing all other help output to stdout already (e.g. "-help",
"-cpu help" and "-machine help" output). So the "-net nic,model=help"
output should go to stdout instead of stderr, too. And while we're at
it, also print the NICs line by line, like we do it e.g. with the
"-cpu help" or "-M help" output, too.
Buglink: https://bugs.launchpad.net/qemu/+bug/1574327
Signed-off-by: Thomas Huth <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
---
net/net.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/net/net.c b/net/net.c
index f3a3c5444cc3..2cf5e7646997 100644
--- a/net/net.c
+++ b/net/net.c
@@ -837,9 +837,10 @@ int qemu_show_nic_models(const char *arg, const char
*const *models)
return 0;
}
- fprintf(stderr, "qemu: Supported NIC models: ");
- for (i = 0 ; models[i]; i++)
- fprintf(stderr, "%s%c", models[i], models[i+1] ? ',' : '\n');
+ printf("Supported NIC models:\n");
+ for (i = 0 ; models[i]; i++) {
+ printf("%s\n", models[i]);
+ }
return 1;
}
--
2.20.1
- [Qemu-devel] [PULL v2 02/12] CODING_STYLE: specify the indent rule for multiline code, (continued)
- [Qemu-devel] [PULL v2 00/12] Trivial branch patches, Laurent Vivier, 2019/05/03
- [Qemu-devel] [PULL v2 01/12] hw/net/pcnet: Use qemu_log_mask(GUEST_ERROR) instead of printf, Laurent Vivier, 2019/05/03
- [Qemu-devel] [PULL v2 06/12] configure: fix pam test warning, Laurent Vivier, 2019/05/03
- [Qemu-devel] [PULL v2 02/12] CODING_STYLE: specify the indent rule for multiline code, Laurent Vivier, 2019/05/03
- [Qemu-devel] [PULL v2 07/12] Update configure, Laurent Vivier, 2019/05/03
- [Qemu-devel] [PULL v2 03/12] CODING_STYLE: indent example code as all others, Laurent Vivier, 2019/05/03
- [Qemu-devel] [PULL v2 08/12] Header cleanups, Laurent Vivier, 2019/05/03
- [Qemu-devel] [PULL v2 09/12] net: Print output of "-net nic, model=help" to stdout instead of stderr,
Laurent Vivier <=
- [Qemu-devel] [PULL v2 04/12] doc: fix the configuration path, Laurent Vivier, 2019/05/03
- [Qemu-devel] [PULL v2 05/12] qom: use object_new_with_type in object_new_with_propv, Laurent Vivier, 2019/05/03
- [Qemu-devel] [PULL v2 10/12] Makefile: Let the 'clean' rule remove qemu-ga.exe on Windows hosts, Laurent Vivier, 2019/05/03
- [Qemu-devel] [PULL v2 11/12] hw/sparc/leon3: Allow load of uImage firmwares, Laurent Vivier, 2019/05/03
- [Qemu-devel] [PULL v2 12/12] sockets: avoid string truncation warnings when copying UNIX path, Laurent Vivier, 2019/05/03
- Re: [Qemu-devel] [PULL v2 00/12] Trivial branch patches, Laurent Vivier, 2019/05/07