[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v2 03/12] CODING_STYLE: indent example code as all ot
From: |
Laurent Vivier |
Subject: |
[Qemu-devel] [PULL v2 03/12] CODING_STYLE: indent example code as all others |
Date: |
Fri, 3 May 2019 13:19:49 +0200 |
From: Wei Yang <address@hidden>
All the example code are indented with four spaces except this one.
Fix this by adding four spaces here.
Signed-off-by: Wei Yang <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Reviewed-by: Stefano Garzarella <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
---
CODING_STYLE | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/CODING_STYLE b/CODING_STYLE
index 90321e9c2821..cb8edcbb3692 100644
--- a/CODING_STYLE
+++ b/CODING_STYLE
@@ -147,10 +147,10 @@ block to a separate function altogether.
When comparing a variable for (in)equality with a constant, list the
constant on the right, as in:
-if (a == 1) {
- /* Reads like: "If a equals 1" */
- do_something();
-}
+ if (a == 1) {
+ /* Reads like: "If a equals 1" */
+ do_something();
+ }
Rationale: Yoda conditions (as in 'if (1 == a)') are awkward to read.
Besides, good compilers already warn users when '==' is mis-typed as '=',
--
2.20.1
- [Qemu-devel] [PULL v2 02/12] CODING_STYLE: specify the indent rule for multiline code, (continued)
- [Qemu-devel] [PULL v2 02/12] CODING_STYLE: specify the indent rule for multiline code, Laurent Vivier, 2019/05/03
- [Qemu-devel] [PULL v2 01/12] hw/net/pcnet: Use qemu_log_mask(GUEST_ERROR) instead of printf, Laurent Vivier, 2019/05/03
- [Qemu-devel] [PULL v2 05/12] qom: use object_new_with_type in object_new_with_propv, Laurent Vivier, 2019/05/03
- [Qemu-devel] [PULL v2 06/12] configure: fix pam test warning, Laurent Vivier, 2019/05/03
- [Qemu-devel] [PULL v2 04/12] doc: fix the configuration path, Laurent Vivier, 2019/05/03
- [Qemu-devel] [PULL v2 07/12] Update configure, Laurent Vivier, 2019/05/03
- Re: [Qemu-devel] [PULL v2 00/12] Trivial branch patches, Laurent Vivier, 2019/05/03
- [Qemu-devel] [PULL v2 00/12] Trivial branch patches, Laurent Vivier, 2019/05/03
- [Qemu-devel] [PULL v2 01/12] hw/net/pcnet: Use qemu_log_mask(GUEST_ERROR) instead of printf, Laurent Vivier, 2019/05/03
- [Qemu-devel] [PULL v2 04/12] doc: fix the configuration path, Laurent Vivier, 2019/05/03
- [Qemu-devel] [PULL v2 03/12] CODING_STYLE: indent example code as all others,
Laurent Vivier <=
- [Qemu-devel] [PULL v2 07/12] Update configure, Laurent Vivier, 2019/05/03
- [Qemu-devel] [PULL v2 06/12] configure: fix pam test warning, Laurent Vivier, 2019/05/03
- [Qemu-devel] [PULL v2 02/12] CODING_STYLE: specify the indent rule for multiline code, Laurent Vivier, 2019/05/03
- [Qemu-devel] [PULL v2 05/12] qom: use object_new_with_type in object_new_with_propv, Laurent Vivier, 2019/05/03
- Re: [Qemu-devel] [PULL v2 00/12] Trivial branch patches, Laurent Vivier, 2019/05/03
- [Qemu-devel] [PULL v2 00/12] Trivial branch patches, Laurent Vivier, 2019/05/03