[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 1/2] configure: set source_path only once and mak
From: |
Antonio Ospite |
Subject: |
[Qemu-devel] [PATCH v2 1/2] configure: set source_path only once and make its definition more robust |
Date: |
Fri, 3 May 2019 10:27:27 +0200 |
From: Antonio Ospite <address@hidden>
Since commit 79d77bcd36 (configure: Remove --source-path option,
2019-04-29) source_path cannot be overridden anymore, move it out of the
"default parameters" block since the word "default" may suggest that the
value can change, while in fact it does not.
While at it, only set source_path once and separate the positional
argument of basename with "--" to more robustly cover the case of path
names starting with a dash.
Signed-off-by: Antonio Ospite <address@hidden>
---
configure | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/configure b/configure
index 60719ddcc5..9832cbca5c 100755
--- a/configure
+++ b/configure
@@ -276,10 +276,10 @@ ld_has() {
$ld --help 2>/dev/null | grep ".$1" >/dev/null 2>&1
}
-# default parameters
-source_path=$(dirname "$0")
# make source path absolute
-source_path=$(cd "$source_path"; pwd)
+source_path=$(cd "$(dirname -- "$0")"; pwd)
+
+# default parameters
cpu=""
iasl="iasl"
interp_prefix="/usr/gnemul/qemu-%M"
--
2.20.1
- [Qemu-devel] [PATCH v2 0/2] configure: disallow spaces and colons in source path and build path, Antonio Ospite, 2019/05/03
- [Qemu-devel] [PATCH v2 2/2] configure: disallow spaces and colons in source path and build path, Antonio Ospite, 2019/05/03
- Re: [Qemu-devel] [PATCH v2 2/2] configure: disallow spaces and colons in source path and build path, Eric Blake, 2019/05/06
- Re: [Qemu-devel] [PATCH v2 2/2] configure: disallow spaces and colons in source path and build path, Antonio Ospite, 2019/05/06
- Re: [Qemu-devel] [PATCH v2 2/2] configure: disallow spaces and colons in source path and build path, Peter Maydell, 2019/05/09
- Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 2/2] configure: disallow spaces and colons in source path and build path, Laurent Vivier, 2019/05/22
- Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 2/2] configure: disallow spaces and colons in source path and build path, Antonio Ospite, 2019/05/22
- Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 2/2] configure: disallow spaces and colons in source path and build path, Laurent Vivier, 2019/05/22
- Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 2/2] configure: disallow spaces and colons in source path and build path, Antonio Ospite, 2019/05/22
- Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 2/2] configure: disallow spaces and colons in source path and build path, Laurent Vivier, 2019/05/22
[Qemu-devel] [PATCH v2 1/2] configure: set source_path only once and make its definition more robust,
Antonio Ospite <=