Re: [Qemu-devel] [PATCH v8 00/27] gdbstub: Refactor command packets handler

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v8 00/27] gdbstub: Refactor command packets handler

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
0d6fab91ff gdbstub: Add support to write a MSR for KVM target
b721d643cf gdbstub: Add support to read a MSR for KVM target
1869da1051 kvm: Add API to read/write a CPU MSR value
bcc325bde5 gdbstub: Add another handler for setting qemu.sstep
0a49df3f08 gdbstub: Implement qemu physical memory mode
cd5628aec4 gdbstub: Implement generic query qemu.Supported
32c453e60e gdbstub: Clear unused variables in gdb_handle_packet
ccb96f9964 gdbstub: Implement target halted (? pkt) with new infra
bb0a145e21 gdbstub: Implement generic set (Q pkt) with new infra
64377b7341 gdbstub: Implement generic query (q pkt) with new infra
020992474d gdbstub: Implement v commands with new infra
db408e69a6 gdbstub: Implement step (s pkt) with new infra
2a89ed74eb gdbstub: Implement file io (F pkt) with new infra
73c45c3cfd gdbstub: Implement read all registers (g pkt) with new infra
fe47484b0d gdbstub: Implement write all registers (G pkt) with new infra
0e2d610881 gdbstub: Implement read memory (m pkt) with new infra
cda888ce18 gdbstub: Implement write memory (M pkt) with new infra
a8918c40b6 gdbstub: Implement get register (p pkt) with new infra
1ea1df5075 gdbstub: Implement set register (P pkt) with new infra
5d1aca0833 gdbstub: Implement remove breakpoint (z pkt) with new infra
9195b39b65 gdbstub: Implement insert breakpoint (Z pkt) with new infra
cee2f9baa6 gdbstub: Implement set_thread (H pkt) with new infra
f5064441f3 gdbstub: Implement continue with signal (C pkt) with new infra
0c25166462 gdbstub: Implement continue (c pkt) with new infra
ae4ba6e5ae gdbstub: Implement thread_alive (T pkt) with new infra
7193ba9fef gdbstub: Implement deatch (D pkt) with new infra
d4e82caefb gdbstub: Add infrastructure to parse cmd packets

=== OUTPUT BEGIN ===
1/27 Checking commit d4e82caefb43 (gdbstub: Add infrastructure to parse cmd 
packets)
2/27 Checking commit 7193ba9fef09 (gdbstub: Implement deatch (D pkt) with new 
infra)
3/27 Checking commit ae4ba6e5ae01 (gdbstub: Implement thread_alive (T pkt) with 
new infra)
4/27 Checking commit 0c2516646203 (gdbstub: Implement continue (c pkt) with new 
infra)
5/27 Checking commit f5064441f32c (gdbstub: Implement continue with signal (C 
pkt) with new infra)
6/27 Checking commit cee2f9baa61b (gdbstub: Implement set_thread (H pkt) with 
new infra)
7/27 Checking commit 9195b39b6558 (gdbstub: Implement insert breakpoint (Z pkt) 
with new infra)
8/27 Checking commit 5d1aca083395 (gdbstub: Implement remove breakpoint (z pkt) 
with new infra)
9/27 Checking commit 1ea1df5075bf (gdbstub: Implement set register (P pkt) with 
new infra)
10/27 Checking commit a8918c40b6ff (gdbstub: Implement get register (p pkt) 
with new infra)
11/27 Checking commit cda888ce18a3 (gdbstub: Implement write memory (M pkt) 
with new infra)
12/27 Checking commit 0e2d61088100 (gdbstub: Implement read memory (m pkt) with 
new infra)
13/27 Checking commit fe47484b0dae (gdbstub: Implement write all registers (G 
pkt) with new infra)
14/27 Checking commit 73c45c3cfdb8 (gdbstub: Implement read all registers (g 
pkt) with new infra)
15/27 Checking commit 2a89ed74eb71 (gdbstub: Implement file io (F pkt) with new 
infra)
16/27 Checking commit db408e69a6b3 (gdbstub: Implement step (s pkt) with new 
infra)
17/27 Checking commit 020992474d0f (gdbstub: Implement v commands with new 
infra)
18/27 Checking commit 64377b73417b (gdbstub: Implement generic query (q pkt) 
with new infra)
19/27 Checking commit bb0a145e216d (gdbstub: Implement generic set (Q pkt) with 
new infra)
20/27 Checking commit ccb96f99648b (gdbstub: Implement target halted (? pkt) 
with new infra)
21/27 Checking commit 32c453e60ec9 (gdbstub: Clear unused variables in 
gdb_handle_packet)
22/27 Checking commit cd5628aec4d1 (gdbstub: Implement generic query 
qemu.Supported)
23/27 Checking commit 0a49df3f08f1 (gdbstub: Implement qemu physical memory 
mode)
ERROR: do not initialise statics to 0 or NULL
#26: FILE: gdbstub.c:49:
+static int phy_memory_mode = 0;

total: 1 errors, 0 warnings, 86 lines checked

Patch 23/27 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

24/27 Checking commit bcc325bde5be (gdbstub: Add another handler for setting 
qemu.sstep)
25/27 Checking commit 1869da105177 (kvm: Add API to read/write a CPU MSR value)
26/27 Checking commit b721d643cf8c (gdbstub: Add support to read a MSR for KVM 
target)
27/27 Checking commit 0d6fab91ff07 (gdbstub: Add support to write a MSR for KVM 
target)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden