Re: [Qemu-devel] [PATCH v2 2/8] tests/qemu-iotests/005: Add a sanity check for large sparse file support

[Alex Bennée]

Thomas Huth <address@hidden> writes:

> "check -raw 005" fails when running on ext4 filesystems - these do not
> support such large sparse files. Use the same check as in test 220 to
> skip the test in this case.
>
> Suggested-by: Eric Blake <address@hidden>
> Signed-off-by: Thomas Huth <address@hidden>
> ---
>  tests/qemu-iotests/005 | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/tests/qemu-iotests/005 b/tests/qemu-iotests/005
> index 2fef63af88..6136ced5c8 100755
> --- a/tests/qemu-iotests/005
> +++ b/tests/qemu-iotests/005
> @@ -55,6 +55,15 @@ if [ "$IMGPROTO" = "sheepdog" ]; then
>      _notrun "image protocol $IMGPROTO does not support large image sizes"
>  fi
>
> +# Sanity check: For raw, we require a file system that permits the creation
> +# of a HUGE (but very sparse) file.  tmpfs works, ext4 does not.

Is this comment correct? Running on my ext4 home partition this test
seems to be running fine and not skipping. Indeed:

  12:06:29 address@hidden:~/l/q/b/k/t/qemu-iotests] review/iotests-fixup-v2 + 
pwd
  /home/alex/lsrc/qemu.git/builds/kvm/tests/qemu-iotests
  12:07:12 address@hidden:~/l/q/b/k/t/qemu-iotests] review/iotests-fixup-v2 + 
stat -f -c %T .
  ext2/ext3
  12:07:40 address@hidden:~/l/q/b/k/t/qemu-iotests] review/iotests-fixup-v2 + 
touch scratch/t.img
  12:07:45 address@hidden:~/l/q/b/k/t/qemu-iotests] review/iotests-fixup-v2 + 
truncate --size=5T scratch/t.img
  12:07:47 address@hidden:~/l/q/b/k/t/qemu-iotests] review/iotests-fixup-v2 + 
ls -lh scratch/t.img
  -rw-r--r-- 1 alex alex 5.0T May  1 12:07 scratch/t.img
  12:07:51 address@hidden:~/l/q/b/k/t/qemu-iotests] review/iotests-fixup-v2 + 
stat -f -c %T scratch/t.img
  ext2/ext3
  12:07:58 address@hidden:~/l/q/b/k/t/qemu-iotests] review/iotests-fixup-v2 + 
du -sh scratch/
  4.0K    scratch/


> +if [ "$IMGFMT" = "raw" ]; then
> +    if ! truncate --size=5T "$TEST_IMG"; then
> +        _notrun "file system on $TEST_DIR does not support large enough 
> files"
> +    fi
> +    rm "$TEST_IMG"
> +fi
> +
>  echo
>  echo "creating large image"
>  _make_test_img 5000G

--
Alex Bennée