[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-arm] [PATCH 04/26] target/arm: Convert to CPUClas
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [Qemu-arm] [PATCH 04/26] target/arm: Convert to CPUClass::tlb_fill |
Date: |
Tue, 30 Apr 2019 13:02:07 +0100 |
On Wed, 3 Apr 2019 at 06:14, Peter Maydell <address@hidden> wrote:
>
> On Wed, 3 Apr 2019 at 10:44, Richard Henderson
> <address@hidden> wrote:
>
> > +bool arm_cpu_tlb_fill(CPUState *cs, vaddr address, int size,
> > + MMUAccessType access_type, int mmu_idx,
> > + bool probe, uintptr_t retaddr)
> > +{
> > + ARMCPU *cpu = ARM_CPU(cs);
> > +
> > +#ifdef CONFIG_USER_ONLY
> > + cpu->env.exception.vaddress = address;
> > + if (access_type == MMU_INST_FETCH) {
> > + cs->exception_index = EXCP_PREFETCH_ABORT;
> > + } else {
> > + cs->exception_index = EXCP_DATA_ABORT;
> > + }
> > + cpu_loop_exit_restore(cs, retaddr);
> > +#else
> > + hwaddr phys_addr;
> > + target_ulong page_size;
> > + int prot, ret;
> > + MemTxAttrs attrs = {};
> > + ARMMMUFaultInfo fi = {};
> > +
> > + /*
> > + * Walk the page table and (if the mapping exists) add the page
> > + * to the TLB. Return false on success, or true on failure. Populate
> > + * fsr with ARM DFSR/IFSR fault register format value on failure.
> > + */
>
> This comment about what we return doesn't seem to match what
> the code is doing.
Other than fixing up the comment,
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
- [Qemu-devel] [PATCH 01/26] tcg: Assert h2g_valid for 32-bit guest on 64-bit host, (continued)
- [Qemu-devel] [PATCH 01/26] tcg: Assert h2g_valid for 32-bit guest on 64-bit host, Richard Henderson, 2019/04/02
- [Qemu-devel] [PATCH 02/26] tcg: Add CPUClass::tlb_fill, Richard Henderson, 2019/04/02
- [Qemu-devel] [PATCH 03/26] target/alpha: Convert to CPUClass::tlb_fill, Richard Henderson, 2019/04/02
- [Qemu-devel] [PATCH 04/26] target/arm: Convert to CPUClass::tlb_fill, Richard Henderson, 2019/04/02
- [Qemu-devel] [PATCH 05/26] target/cris: Convert to CPUClass::tlb_fill, Richard Henderson, 2019/04/02
- [Qemu-devel] [PATCH 06/26] target/hppa: Convert to CPUClass::tlb_fill, Richard Henderson, 2019/04/02
- [Qemu-devel] [PATCH 08/26] target/lm32: Convert to CPUClass::tlb_fill, Richard Henderson, 2019/04/02
- [Qemu-devel] [PATCH 07/26] target/i386: Convert to CPUClass::tlb_fill, Richard Henderson, 2019/04/02
- [Qemu-devel] [PATCH 09/26] target/m68k: Convert to CPUClass::tlb_fill, Richard Henderson, 2019/04/02