[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Revert "armv7m: Guard against no -kernel argume
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] Revert "armv7m: Guard against no -kernel argument" |
Date: |
Mon, 29 Apr 2019 13:58:46 +0100 |
On Mon, 29 Apr 2019 at 13:28, Stefan Hajnoczi <address@hidden> wrote:
>
> On Fri, Apr 26, 2019 at 12:45:37PM +0100, Peter Maydell wrote:
> I was going to add a function to check kernel_filename and the presence
> of -device loader. Then each machine type init function would call the
> function with flags indicating which modes are allowed:
>
> /* Allow both -kernel and -device loader */
> check_kernel_loaded(KERNEL_CMDLINE | KERNEL_LOADER);
>
> /* Allow only -kernel */
> check_kernel_loaded(KERNEL_CMDLINE);
>
> /* Allow only -device loader */
> check_kernel_loaded(KERNEL_LOADER);
Every machine should permit -device loader: the point
of it is that it is entirely generic and works the same
way on every machine.
thanks
-- PMM