[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] migration/colo.c: Remove redundant input pa
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] migration/colo.c: Remove redundant input parameter |
Date: |
Mon, 29 Apr 2019 13:21:36 +0100 |
User-agent: |
Mutt/1.11.4 (2019-03-13) |
* Zhang Chen (address@hidden) wrote:
> From: Zhang Chen <address@hidden>
>
> The colo_do_failover no need the input parameter.
>
> Signed-off-by: Zhang Chen <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> ---
> include/migration/colo.h | 2 +-
> migration/colo-failover.c | 2 +-
> migration/colo.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/migration/colo.h b/include/migration/colo.h
> index 99ce17aca7..ddebe0ad27 100644
> --- a/include/migration/colo.h
> +++ b/include/migration/colo.h
> @@ -37,7 +37,7 @@ bool migration_incoming_in_colo_state(void);
> COLOMode get_colo_mode(void);
>
> /* failover */
> -void colo_do_failover(MigrationState *s);
> +void colo_do_failover(void);
>
> void colo_checkpoint_notify(void *opaque);
> #endif
> diff --git a/migration/colo-failover.c b/migration/colo-failover.c
> index 4854a96c92..e9ca0b4774 100644
> --- a/migration/colo-failover.c
> +++ b/migration/colo-failover.c
> @@ -39,7 +39,7 @@ static void colo_failover_bh(void *opaque)
> return;
> }
>
> - colo_do_failover(NULL);
> + colo_do_failover();
> }
>
> void failover_request_active(Error **errp)
> diff --git a/migration/colo.c b/migration/colo.c
> index 238a6d62c7..8c1644091f 100644
> --- a/migration/colo.c
> +++ b/migration/colo.c
> @@ -193,7 +193,7 @@ COLOMode get_colo_mode(void)
> }
> }
>
> -void colo_do_failover(MigrationState *s)
> +void colo_do_failover(void)
> {
> /* Make sure VM stopped while failover happened. */
> if (!colo_runstate_is_stopped()) {
> --
> 2.17.GIT
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK