Re: [Qemu-devel] [PATCH v6 04/11] contrib: add vhost-user-input

[Marc-André Lureau]

Hi

On Fri, Apr 26, 2019 at 9:16 AM Gerd Hoffmann <address@hidden> wrote:
>
> On Tue, Apr 23, 2019 at 03:19:57PM +0200, Marc-André Lureau wrote:
> > Add a vhost-user input backend example, based on virtio-input-host
> > device. It takes an evdev path as argument, and can be associated with
> > a vhost-user-input device via a UNIX socket:
> >
> > $ vhost-user-input -p /dev/input/eventX -s /tmp/vui.sock
> >
> > $ qemu ... -chardev socket,id=vuic,path=/tmp/vui.sock
> >   -device vhost-user-input-pci,chardev=vuic
> >
> > This example is intentionally not included in $TOOLS, to not be built
> > and installed by default.
>
> I think we should build it by default, so it doesn't bitrot,
> even if we don't install it by default.
>
> > +static int unix_sock_new(char *path)
> > +{
>
> Move to common code?
>

Better, use existing unix_listen()!

thanks



-- 
Marc-André Lureau