[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hvf: Add missing break statement
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH] hvf: Add missing break statement |
|
Date: |
Fri, 26 Apr 2019 09:57:06 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 22/04/19 18:09, Philippe Mathieu-Daudé wrote:
> Oops... I'm surprised no compiler warned about this yet...
>
> This probably mean:
> - This code is not covered by Continuous Integration
> - Upstream maintainers are not building this code
> - Upstream is not running this code
>
> Please tell me I'm wrong!
Indeed I am not building or running this code since it requires a Mac.
I am thinking of adding a Patchew builder on macincloud, but I haven't
done it yet.
However, it is unlikely to be signaled by a compiler---maybe by
Coverity. Probably the return value doesn't mean much to the rest of
the code, the "cpu->halted = 1" is what counts. I have queued the patch.
Paolo