[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 05/13] tests: acpi: skip FACS table if board
From: |
Wei Yang |
Subject: |
Re: [Qemu-devel] [PATCH v3 05/13] tests: acpi: skip FACS table if board uses hw reduced ACPI profile |
Date: |
Thu, 25 Apr 2019 15:48:13 +0800 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Thu, Apr 25, 2019 at 07:34:41AM +0200, Igor Mammedov wrote:
>If FADT has HW_REDUCED_ACPI flag set, do not attempt to fetch
>FACS as it's not provided by the board.
>
>Signed-off-by: Igor Mammedov <address@hidden>
>Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Wei Yang <address@hidden>
>---
> tests/bios-tables-test.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
>diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c
>index ed62a17..e944d00 100644
>--- a/tests/bios-tables-test.c
>+++ b/tests/bios-tables-test.c
>@@ -146,9 +146,13 @@ static void test_acpi_fadt_table(test_data *data)
> g_assert(compare_signature(&table, "FACP"));
>
> /* Since DSDT/FACS isn't in RSDT, add them to ASL test list manually */
>- acpi_fetch_table(data->qts, &table.aml, &table.aml_len,
>- fadt_aml + 36 /* FIRMWARE_CTRL */, "FACS", false);
>- g_array_append_val(data->tables, table);
>+ memcpy(&val, fadt_aml + 112 /* Flags */, 4);
>+ val = le32_to_cpu(val);
>+ if (!(val & 1UL << 20 /* HW_REDUCED_ACPI */)) {
>+ acpi_fetch_table(data->qts, &table.aml, &table.aml_len,
>+ fadt_aml + 36 /* FIRMWARE_CTRL */, "FACS", false);
>+ g_array_append_val(data->tables, table);
>+ }
>
> memcpy(&val, fadt_aml + dsdt_offset, 4);
> val = le32_to_cpu(val);
>--
>2.7.4
--
Wei Yang
Help you, Help me
- [Qemu-devel] [PATCH v3 11/13] tests: acpi: add simple arm/virt testcase, (continued)
- [Qemu-devel] [PATCH v3 11/13] tests: acpi: add simple arm/virt testcase, Igor Mammedov, 2019/04/25
- [Qemu-devel] [PATCH v3 10/13] tests: add expected ACPI tables for arm/virt board, Igor Mammedov, 2019/04/25
- [Qemu-devel] [PATCH v3 09/13] tests: acpi: ignore SMBIOS tests when UEFI firmware is used, Igor Mammedov, 2019/04/25
- [Qemu-devel] [PATCH v3 08/13] tests: acpi: add a way to start tests with UEFI firmware, Igor Mammedov, 2019/04/25
- [Qemu-devel] [PATCH v3 07/13] tests: acpi: add acpi_find_rsdp_address_uefi() helper, Igor Mammedov, 2019/04/25
- [Qemu-devel] [PATCH v3 06/13] tests: acpi: move boot_sector_init() into x86 tests branch, Igor Mammedov, 2019/04/25
- [Qemu-devel] [PATCH v3 05/13] tests: acpi: skip FACS table if board uses hw reduced ACPI profile, Igor Mammedov, 2019/04/25
- Re: [Qemu-devel] [PATCH v3 05/13] tests: acpi: skip FACS table if board uses hw reduced ACPI profile,
Wei Yang <=
- [Qemu-devel] [PATCH v3 04/13] tests: acpi: fetch X_DSDT if pointer to DSDT is 0, Igor Mammedov, 2019/04/25
- [Qemu-devel] [PATCH v3 03/13] tests: acpi: make pointer to RSDP 64bit, Igor Mammedov, 2019/04/25
- [Qemu-devel] [PATCH v3 02/13] tests: acpi: rename acpi_parse_rsdp_table() into acpi_fetch_rsdp_table(), Igor Mammedov, 2019/04/25
- [Qemu-devel] [PATCH v3 01/13] tests: acpi: make RSDT test routine handle XSDT, Igor Mammedov, 2019/04/25