[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] qapi: SupportStatusInfo struct
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] qapi: SupportStatusInfo struct |
Date: |
Wed, 24 Apr 2019 00:23:33 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
Hi Eduardo,
On 4/23/19 11:22 PM, Eduardo Habkost wrote:
> This struct will be used to represent support and deprecation
> status of QEMU features.
Excellent idea!
>
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
> qapi/common.json | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/qapi/common.json b/qapi/common.json
> index 99d313ef3b..b59d0dc66b 100644
> --- a/qapi/common.json
> +++ b/qapi/common.json
> @@ -193,3 +193,27 @@
> 'ppc64', 'riscv32', 'riscv64', 's390x', 'sh4',
> 'sh4eb', 'sparc', 'sparc64', 'tricore', 'unicore32',
> 'x86_64', 'xtensa', 'xtensaeb' ] }
> +
> +##
> +# @SupportStatusInfo:
> +#
> +# Information on support status of a given feature
> +# (e.g. machine type)
Hopefully it is generic, we can use it for devices too.
> +#
> +# @deprecated: if true, the given feature is deprecated and may be removed
> +# in future versions of QEMU according to the QEMU deprecation
> +# policy.
> +#
> +# @status-message: Human readable message describing support status
> +# of the feature.
> +#
> +# @suggested-alternative: Optional. Suggested alternative for a deprecated
> +# feature. For machine types, this should be the
> name
> +# of an available machine-type.
> +#
> +# Since: 4.1
> +##
> +{ 'struct': 'SupportStatusInfo',
> + 'data': { 'deprecated': 'bool',
> + '*status-message': 'str',
This one shouldn't be optional IMHO, we should enforce developpers to
give a reason for their deprecation.
With this argument not optional:
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> + '*suggested-alternative': 'str' } }
>
Re: [Qemu-devel] [PATCH 1/3] qapi: SupportStatusInfo struct, Wainer dos Santos Moschetta, 2019/04/25
[Qemu-devel] [PATCH 3/3] qmp: Add deprecation information to query-machines, Eduardo Habkost, 2019/04/23