[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] qtest: Move accel code to accel/qtest.c
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/3] qtest: Move accel code to accel/qtest.c |
|
Date: |
Mon, 22 Apr 2019 19:08:14 -0300 |
|
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Mon, Apr 22, 2019 at 11:56:18PM +0200, Philippe Mathieu-Daudé wrote:
> Hi Eduardo,
>
> On 4/22/19 11:04 PM, Eduardo Habkost wrote:
> > QTest has two parts: the server (-qtest) and the accelerator
> > (-machine accel=qtest). The accelerator depends on CONFIG_POSIX
> > due to its usage of sigwait(), but the server doesn't.
> >
> > Move the accel code to accel/qtest.c. Later we will disable
> > compilation of accel/qtest.c on non-POSIX systems.
> >
[...]
> > +#include "qemu/module.h"
>
> Why include "qemu/module.h"?
> I guess you don't need it.
That's where the type_init() macro is defined.
> > +type_init(qtest_type_init);
[...]
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> Tested-by: Philippe Mathieu-Daudé <address@hidden>
Thanks!
--
Eduardo