[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] cputlb: Fix io_readx() to respect the access
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH v3] cputlb: Fix io_readx() to respect the access_type |
|
Date: |
Fri, 19 Apr 2019 21:36:44 -1000 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 4/19/19 9:22 PM, Shahab Vahedi wrote:
> This change adapts io_readx() to its input access_type. Currently
> io_readx() treats any memory access as a read, although it has an
> input argument "MMUAccessType access_type". This results in:
>
> 1) Calling the tlb_fill() only with MMU_DATA_LOAD
> 2) Considering only entry->addr_read as the tlb_addr
>
> Buglink: https://bugs.launchpad.net/qemu/+bug/1825359
>
> Signed-off-by: Shahab Vahedi <address@hidden>
> ---
> Changelog:
> v3
> - Only handle read/fetch. There must be no write access.
>
> v2
> - Extra space before closing parenthesis is removed
>
> v1
> - Initial submit
>
> accel/tcg/cputlb.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~