Re: [Qemu-devel] [PULL for-4.1 00/36] Error reporting & monitor patches for 2019-04-18

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PULL for-4.1 00/36] Error reporting & monitor patches 
for 2019-04-18

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
f65f9a57a6 include: Move fprintf_function to disas/
3613cf2952 disas: Rename include/disas/bfd.h back to include/disas/dis-asm.h
8362074a2c monitor: Clean up how monitor_disas() funnels output to monitor
41465772c0 qom/cpu: Simplify how CPUClass:cpu_dump_state() prints
49fd3a8181 qemu-print: New qemu_fprintf(), qemu_vfprintf()
195a57362a qom/cpu: Simplify how CPUClass::dump_statistics() prints
b439ddf49d target/i386: Simplify how x86_cpu_dump_local_apic_state() prints
f02a059161 target: Clean up how the dump_mmu() print
71ad53d2d8 target: Simplify how the TARGET_cpu_list() print
e48c937bbb memory: Clean up how mtree_info() prints
de799bd96a block/qapi: Clean up how we print to monitor or stdout
de39c5a100 qsp: Simplify how qsp_report() prints
e597dab6a6 tcg: Simplify how dump_drift_info() prints
903672bb0a tcg: Simplify how dump_exec_info() prints
b011a591b1 tcg: Simplify how dump_opcount_info() prints
e2066e0297 trace: Simplify how st_print_trace_file_status() prints
ba66678390 include: Include fprintf-fn.h only where needed
6bf830e5fa monitor: Simplify how -device/device_add print help
f9837a2629 char-pty: Print "char device redirected" message to stdout
8ffea401ea char: Make -chardev help print to stdout
7e517c0c83 blockdev: Make -drive format=help print to stdout
4fc29bdae6 qemu-print: New qemu_printf(), qemu_vprintf() etc.
da66543644 monitor error: Make printf()-like functions return a value
bb86c3751c vl: Make -machine $TYPE, help and -accel help print to stdout
f0f1843fa5 s390x/kvm: Report warnings with warn_report(), not error_printf()
30004a79dd vfio: Report warnings with warn_report(), not error_printf()
86648932be hpet: Report warnings with warn_report(), not error_printf()
77849d6ae3 pci: Report fatal errors with error_report(), not error_printf()
5384051d57 mips/boston: Report errors with error_report(), not error_printf()
5542ac28ff loader-fit: Wean off error_printf()
390e511dee block/ssh: Do not report read/write/flush errors to the user
85da455e60 qemu-img: Use error_vreport() in error_exit()
376c0acbff util/error: do not free error on error_abort
d515fdf4f0 error: Fix error_report_err(), warn_report_err() hint printing
d4406797be log: Make glib logging go through QEMU
3c051888c6 qemu-io: Use error_[gs]et_progname()

=== OUTPUT BEGIN ===
1/36 Checking commit 3c051888c617 (qemu-io: Use error_[gs]et_progname())
2/36 Checking commit d4406797beb3 (log: Make glib logging go through QEMU)
3/36 Checking commit d515fdf4f02b (error: Fix error_report_err(), 
warn_report_err() hint printing)
4/36 Checking commit 376c0acbff33 (util/error: do not free error on error_abort)
5/36 Checking commit 85da455e604b (qemu-img: Use error_vreport() in 
error_exit())
6/36 Checking commit 390e511dee92 (block/ssh: Do not report read/write/flush 
errors to the user)
7/36 Checking commit 5542ac28ff9b (loader-fit: Wean off error_printf())
8/36 Checking commit 5384051d5721 (mips/boston: Report errors with 
error_report(), not error_printf())
9/36 Checking commit 77849d6ae3cf (pci: Report fatal errors with 
error_report(), not error_printf())
10/36 Checking commit 86648932bea9 (hpet: Report warnings with warn_report(), 
not error_printf())
11/36 Checking commit 30004a79dd0d (vfio: Report warnings with warn_report(), 
not error_printf())
12/36 Checking commit f0f1843fa518 (s390x/kvm: Report warnings with 
warn_report(), not error_printf())
13/36 Checking commit bb86c3751c7d (vl: Make -machine $TYPE, help and -accel 
help print to stdout)
14/36 Checking commit da6654364435 (monitor error: Make printf()-like functions 
return a value)
15/36 Checking commit 4fc29bdae6ff (qemu-print: New qemu_printf(), 
qemu_vprintf() etc.)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#36: 
new file mode 100644

total: 0 errors, 1 warnings, 94 lines checked

Patch 15/36 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/36 Checking commit 7e517c0c8383 (blockdev: Make -drive format=help print to 
stdout)
17/36 Checking commit 8ffea401ea28 (char: Make -chardev help print to stdout)
18/36 Checking commit f9837a26297b (char-pty: Print "char device redirected" 
message to stdout)
19/36 Checking commit 6bf830e5fac5 (monitor: Simplify how -device/device_add 
print help)
20/36 Checking commit ba6667839046 (include: Include fprintf-fn.h only where 
needed)
21/36 Checking commit e2066e029740 (trace: Simplify how 
st_print_trace_file_status() prints)
22/36 Checking commit b011a591b165 (tcg: Simplify how dump_opcount_info() 
prints)
23/36 Checking commit 903672bb0a4a (tcg: Simplify how dump_exec_info() prints)
24/36 Checking commit e597dab6a65a (tcg: Simplify how dump_drift_info() prints)
25/36 Checking commit de39c5a100c3 (qsp: Simplify how qsp_report() prints)
26/36 Checking commit de799bd96ae3 (block/qapi: Clean up how we print to 
monitor or stdout)
27/36 Checking commit e48c937bbbe0 (memory: Clean up how mtree_info() prints)
28/36 Checking commit 71ad53d2d8cf (target: Simplify how the TARGET_cpu_list() 
print)
29/36 Checking commit f02a05916155 (target: Clean up how the dump_mmu() print)
WARNING: line over 80 characters
#950: FILE: target/xtensa/mmu_helper.c:784:
+                    qemu_printf("\tVaddr       Paddr       ASID  Attr RWX 
Cache\n"

total: 0 errors, 1 warnings, 848 lines checked

Patch 29/36 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
30/36 Checking commit b439ddf49dd3 (target/i386: Simplify how 
x86_cpu_dump_local_apic_state() prints)
31/36 Checking commit 195a57362a6f (qom/cpu: Simplify how 
CPUClass::dump_statistics() prints)
32/36 Checking commit 49fd3a8181f6 (qemu-print: New qemu_fprintf(), 
qemu_vfprintf())
33/36 Checking commit 41465772c004 (qom/cpu: Simplify how 
CPUClass:cpu_dump_state() prints)
ERROR: line over 90 characters
#1051: FILE: target/i386/helper.c:419:
+        qemu_fprintf(f, "RAX=%016" PRIx64 " RBX=%016" PRIx64 " RCX=%016" 
PRIx64 " RDX=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1052: FILE: target/i386/helper.c:420:
+                     "RSI=%016" PRIx64 " RDI=%016" PRIx64 " RBP=%016" PRIx64 " 
RSP=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1053: FILE: target/i386/helper.c:421:
+                     "R8 =%016" PRIx64 " R9 =%016" PRIx64 " R10=%016" PRIx64 " 
R11=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1054: FILE: target/i386/helper.c:422:
+                     "R12=%016" PRIx64 " R13=%016" PRIx64 " R14=%016" PRIx64 " 
R15=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1055: FILE: target/i386/helper.c:423:
+                     "RIP=%016" PRIx64 " RFL=%08x [%c%c%c%c%c%c%c] CPL=%d 
II=%d A20=%d SMM=%d HLT=%d\n",

WARNING: line over 80 characters
#1163: FILE: target/i386/helper.c:494:
+        qemu_fprintf(f, "CR0=%08x CR2=%016" PRIx64 " CR3=%016" PRIx64 " 
CR4=%08x\n",

WARNING: line over 80 characters
#1751: FILE: target/mips/translate.c:29791:
+    qemu_fprintf(f, "CP0 Status  0x%08x Cause   0x%08x EPC    0x" 
TARGET_FMT_lx "\n",

total: 5 errors, 2 warnings, 2551 lines checked

Patch 33/36 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

34/36 Checking commit 8362074a2c1b (monitor: Clean up how monitor_disas() 
funnels output to monitor)
35/36 Checking commit 3613cf29520d (disas: Rename include/disas/bfd.h back to 
include/disas/dis-asm.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#297: 
rename from include/disas/bfd.h

total: 0 errors, 1 warnings, 192 lines checked

Patch 35/36 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
36/36 Checking commit f65f9a57a620 (include: Move fprintf_function to disas/)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#45: 
deleted file mode 100644

total: 0 errors, 1 warnings, 17 lines checked

Patch 36/36 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden