Re: [Qemu-devel] [PATCH 07/10] s390x/cpumodel: deflate

[Christian Borntraeger]

On 18.04.19 17:36, David Hildenbrand wrote:
> On 18.04.19 13:31, Christian Borntraeger wrote:
>> add the deflate conversion facility.
> 
> Nit:
> 
> "s390x/cpumodel: add Deflate-conversion facility"
> 
>>
>> Signed-off-by: Christian Borntraeger <address@hidden>
>> ---
>>  target/s390x/cpu_features.c     |  9 +++++++++
>>  target/s390x/cpu_features.h     |  1 +
>>  target/s390x/cpu_features_def.h |  7 +++++++
>>  target/s390x/gen-features.c     | 12 ++++++++++++
>>  target/s390x/kvm.c              |  6 ++++++
>>  5 files changed, 35 insertions(+)
>>
>> diff --git a/target/s390x/cpu_features.c b/target/s390x/cpu_features.c
>> index e0a4769c19..5f37e655fe 100644
>> --- a/target/s390x/cpu_features.c
>> +++ b/target/s390x/cpu_features.c
>> @@ -110,6 +110,7 @@ static const S390FeatDef s390_features[] = {
>>      FEAT_INIT("cmmnt", S390_FEAT_TYPE_STFL, 147, "CMM: ESSA-enhancement (no 
>> translate) facility"),
>>      FEAT_INIT("vxeh2", S390_FEAT_TYPE_STFL, 148, "Vector Enhancements 
>> facility 2"),
>>      FEAT_INIT("esort-base", S390_FEAT_TYPE_STFL, 150, "Enhanced-sort 
>> facility (excluding subfunctions)"),
>> +    FEAT_INIT("deflate-base", S390_FEAT_TYPE_STFL, 151, "Deflate-conversion 
>> facility (excluding subfunctions)"),
>>      FEAT_INIT("vxbeh", S390_FEAT_TYPE_STFL, 152, "Vector BCD enhancements 
>> facility 1"),
>>      FEAT_INIT("msa9-base", S390_FEAT_TYPE_STFL, 155, 
>> "Message-security-assist-extension-9 facility (excluding subfunctions)"),
>>      FEAT_INIT("etoken", S390_FEAT_TYPE_STFL, 156, "Etoken facility"),
>> @@ -347,6 +348,11 @@ static const S390FeatDef s390_features[] = {
>>      FEAT_INIT("sortl-32", S390_FEAT_TYPE_SORTL, 130, "SORTL 32 input 
>> lists"),
>>      FEAT_INIT("sortl-128", S390_FEAT_TYPE_SORTL, 132, "SORTL 128 input 
>> lists"),
>>      FEAT_INIT("sortl-f0", S390_FEAT_TYPE_SORTL, 192, "SORTL format 0 
>> parameter-block"),
>> +
>> +    FEAT_INIT("dfltcc-gdht", S390_FEAT_TYPE_DFLTCC, 1, "DFLTCC GDHT"),
>> +    FEAT_INIT("dfltcc-cmpr", S390_FEAT_TYPE_DFLTCC, 2, "DFLTCC CMPR"),
>> +    FEAT_INIT("dfltcc-xpnd", S390_FEAT_TYPE_DFLTCC, 4, "DFLTCC XPND"),
>> +    FEAT_INIT("dfltcc-f0", S390_FEAT_TYPE_DFLTCC, 192, "DFLTCC format 0 
>> parameter-block"),
>>  };
> 
> Just wonder, "format 0 parameter-block" is actually a feature right,
> like "format 0 can be used". Can we hide format-0, IOW could that be
> like "query" and always supported? (especially due to backwards
> compatibility)

It hopefully will be there forever but since the CSSKE thing I would not
bet on that. So I see your point but making this explicit seems a bit
safer.