[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/5] linux-user: Use lookup_cpu_class()
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH 3/5] linux-user: Use lookup_cpu_class() |
Date: |
Thu, 18 Apr 2019 01:52:08 -0300 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Tue, Apr 16, 2019 at 11:59:42PM -0300, Eduardo Habkost wrote:
> The return value of cpu_get_model() is just a CPU model name and
> never includes extra options. We don't need to call
> parse_cpu_option().
Oops. I was wrong. linux-user also supports extra features in
the "-cpu" option, so we do need to call parse_cpu_option().
e.g.: this worked before:
$ qemu-x86_64 -cpu Nehalem,+popcnt /bin/true
and now this is broken:
$ qemu-x86_64 -cpu Nehalem,+popcnt /bin/true
unable to find CPU model 'Nehalem,+popcnt'
I will drop patches 2-5 from my queue. Sorry for the noise.
--
Eduardo
- [Qemu-devel] [PATCH 0/5] Remove qdev_get_machine() call from ppc_cpu_parse_featurestr(), Eduardo Habkost, 2019/04/16
- [Qemu-devel] [PATCH 1/5] cpu: Rename parse_cpu_model() to parse_cpu_option(), Eduardo Habkost, 2019/04/16
- [Qemu-devel] [PATCH 2/5] cpu: Extract CPU class lookup from parse_cpu_option(), Eduardo Habkost, 2019/04/16
- [Qemu-devel] [PATCH 3/5] linux-user: Use lookup_cpu_class(), Eduardo Habkost, 2019/04/16
- [Qemu-devel] [PATCH 4/5] bsd-user: Use lookup_cpu_class(), Eduardo Habkost, 2019/04/16
- [Qemu-devel] [PATCH 5/5] cpu: Add MachineState parameter to parse_features(), Eduardo Habkost, 2019/04/16
- Re: [Qemu-devel] [PATCH 0/5] Remove qdev_get_machine() call from ppc_cpu_parse_featurestr(), Markus Armbruster, 2019/04/17