Re: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify around fprintf_function

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify around 
fprintf_function
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
90107e0ecd include: Move fprintf_function to disas/
08c75e94b5 disas: Rename include/disas/bfd.h back to include/disas/dis-asm.h
b35d73a420 monitor: Clean up how monitor_disas() funnels output to monitor
4f0c3493f6 qom/cpu: Simplify how CPUClass:cpu_dump_state() prints
68f63bc7a9 qemu-print: New qemu_fprintf(), qemu_vfprintf()
d41d47ee91 qom/cpu: Simplify how CPUClass::dump_statistics() prints
df73a8c8e6 target/i386: Simplify how x86_cpu_dump_local_apic_state() prints
edc6b2832c target: Clean up how the dump_mmu() print
482f38cd69 target: Simplify how the TARGET_cpu_list() print
18b22c842c memory: Clean up how mtree_info() prints
2dfb27eebe block/qapi: Clean up how we print to monitor or stdout
10b6b38b8a qsp: Simplify how qsp_report() prints
3a161a6792 tcg: Simplify how dump_drift_info() prints
e340f7a5c0 tcg: Simplify how dump_exec_info() prints
bdd8aea085 tcg: Simplify how dump_opcount_info() prints
0cb2f55550 trace: Simplify how st_print_trace_file_status() prints
dcae6b30f1 include: Include fprintf-fn.h only where needed

=== OUTPUT BEGIN ===
1/17 Checking commit dcae6b30f156 (include: Include fprintf-fn.h only where 
needed)
2/17 Checking commit 0cb2f5555029 (trace: Simplify how 
st_print_trace_file_status() prints)
3/17 Checking commit bdd8aea085c0 (tcg: Simplify how dump_opcount_info() prints)
4/17 Checking commit e340f7a5c047 (tcg: Simplify how dump_exec_info() prints)
5/17 Checking commit 3a161a679275 (tcg: Simplify how dump_drift_info() prints)
6/17 Checking commit 10b6b38b8ae9 (qsp: Simplify how qsp_report() prints)
7/17 Checking commit 2dfb27eebe4e (block/qapi: Clean up how we print to monitor 
or stdout)
8/17 Checking commit 18b22c842ccb (memory: Clean up how mtree_info() prints)
9/17 Checking commit 482f38cd6965 (target: Simplify how the TARGET_cpu_list() 
print)
10/17 Checking commit edc6b2832c82 (target: Clean up how the dump_mmu() print)
WARNING: line over 80 characters
#950: FILE: target/xtensa/mmu_helper.c:784:
+                    qemu_printf("\tVaddr       Paddr       ASID  Attr RWX 
Cache\n"

total: 0 errors, 1 warnings, 848 lines checked

Patch 10/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/17 Checking commit df73a8c8e645 (target/i386: Simplify how 
x86_cpu_dump_local_apic_state() prints)
12/17 Checking commit d41d47ee915e (qom/cpu: Simplify how 
CPUClass::dump_statistics() prints)
13/17 Checking commit 68f63bc7a914 (qemu-print: New qemu_fprintf(), 
qemu_vfprintf())
14/17 Checking commit 4f0c3493f69b (qom/cpu: Simplify how 
CPUClass:cpu_dump_state() prints)
ERROR: line over 90 characters
#1051: FILE: target/i386/helper.c:419:
+        qemu_fprintf(f, "RAX=%016" PRIx64 " RBX=%016" PRIx64 " RCX=%016" 
PRIx64 " RDX=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1052: FILE: target/i386/helper.c:420:
+                     "RSI=%016" PRIx64 " RDI=%016" PRIx64 " RBP=%016" PRIx64 " 
RSP=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1053: FILE: target/i386/helper.c:421:
+                     "R8 =%016" PRIx64 " R9 =%016" PRIx64 " R10=%016" PRIx64 " 
R11=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1054: FILE: target/i386/helper.c:422:
+                     "R12=%016" PRIx64 " R13=%016" PRIx64 " R14=%016" PRIx64 " 
R15=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1055: FILE: target/i386/helper.c:423:
+                     "RIP=%016" PRIx64 " RFL=%08x [%c%c%c%c%c%c%c] CPL=%d 
II=%d A20=%d SMM=%d HLT=%d\n",

WARNING: line over 80 characters
#1163: FILE: target/i386/helper.c:494:
+        qemu_fprintf(f, "CR0=%08x CR2=%016" PRIx64 " CR3=%016" PRIx64 " 
CR4=%08x\n",

WARNING: line over 80 characters
#1751: FILE: target/mips/translate.c:29791:
+    qemu_fprintf(f, "CP0 Status  0x%08x Cause   0x%08x EPC    0x" 
TARGET_FMT_lx "\n",

total: 5 errors, 2 warnings, 2551 lines checked

Patch 14/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

15/17 Checking commit b35d73a42067 (monitor: Clean up how monitor_disas() 
funnels output to monitor)
16/17 Checking commit 08c75e94b574 (disas: Rename include/disas/bfd.h back to 
include/disas/dis-asm.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#296: 
rename from include/disas/bfd.h

total: 0 errors, 1 warnings, 192 lines checked

Patch 16/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/17 Checking commit 90107e0ecdfa (include: Move fprintf_function to disas/)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#45: 
deleted file mode 100644

total: 0 errors, 1 warnings, 17 lines checked

Patch 17/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden