[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] tcg: Restart after TB code generation overf
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] tcg: Restart after TB code generation overflow |
Date: |
Tue, 16 Apr 2019 08:48:11 -1000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 4/16/19 7:47 AM, Eric Blake wrote:
> On 4/16/19 3:31 AM, Richard Henderson wrote:
>> If a TB generates too much code, try again with fewer insns.
>>
>> Fixes: https://bugs.launchpad.net/bugs/1824853
>> Signed-off-by: Richard Henderson <address@hidden>
>> ---
>> accel/tcg/translate-all.c | 39 +++++++++++++++++++++++++++++++++------
>> tcg/tcg.c | 4 ++++
>> 2 files changed, 37 insertions(+), 6 deletions(-)
>>
>
>> + * Try again with half as many insns as we attempted this time.
>> + * If a single insn overflows, there's a bug somewhere...
>> + */
>> + max_insns = tb->icount;
>> +qemu_log("TB overflow: pc=%lx insns=%d\n", (unsigned long)pc, max_insns);
>
> Leftover debugging? Or should it be kept but properly indented?
Debugging that I thought I had not committed at all.
That's annoying...
r~