Re: [Qemu-devel] [PATCH v1 20/41] s390x/tcg: Implement VECTOR MULTIPLY *

[Richard Henderson]

On 4/11/19 12:08 AM, David Hildenbrand wrote:
> +static void gen_mh_i32(TCGv_i32 d, TCGv_i32 a, TCGv_i32 b)
> +{
> +    TCGv_i64 t0 = tcg_temp_new_i64();
> +    TCGv_i64 t1 = tcg_temp_new_i64();
> +
> +    tcg_gen_ext_i32_i64(t0, a);
> +    tcg_gen_ext_i32_i64(t1, b);
> +    tcg_gen_mul_i64(t0, t0, t1);
> +    tcg_gen_extrh_i64_i32(d, t0);

This is

  tcg_gen_muls2_i32(tmp, d, a, b);

Similarly for mlh w/ mulu2.

Otherwise,
Reviewed-by: Richard Henderson <address@hidden>


r~