Re: [Qemu-devel] [libvirt] [PATCH for-QEMU-4.1] Declare -realtime as deprecated

[Michal Privoznik]

On 4/11/19 8:03 PM, Daniel P. Berrangé wrote:
> On Thu, Apr 11, 2019 at 07:53:45PM +0200, Thomas Huth wrote:
> > The old -realtime mlock=on|off parameter does exactly the same as the
> > new -overcommit mem-lock=on|off parameter. Additionally, "-realtime"
> > does not activate any additional "realtime" capabilities as the name
> > might indicate. We should avoid to confuse the users this way, so
> > let's deprecate the old -realtime option.
>
> FYI libvirt currently uses  -realtime mlock=on so will need adapting
> to cope with this change.

Done:

e8c2c8bd07 qemu_command: Prefer '-overcommit mem-lock' over -realtime mlock'
be51feff69 qemu_capabilities: Introduce QEMU_CAPS_OVERCOMMIT
a08c4b3741 qemu: Always assume QEMU_CAPS_REALTIME_MLOCK

Therefore, from libvirt's POV this patch is okay to go in.

Michal