[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 08/15] vfio: Report warnings with warn_report(),
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH v2 08/15] vfio: Report warnings with warn_report(), not error_printf() |
Date: |
Thu, 11 Apr 2019 16:52:49 +0200 |
Cc: Alex Williamson <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
---
hw/vfio/pci.c | 19 +++++++++++++------
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index 504019c458..0142819ea6 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@ -947,8 +947,10 @@ static void vfio_pci_size_rom(VFIOPCIDevice *vdev)
if (vdev->pdev.romfile || !vdev->pdev.rom_bar) {
/* Since pci handles romfile, just print a message and return */
if (vfio_blacklist_opt_rom(vdev) && vdev->pdev.romfile) {
- error_printf("Warning : Device at %s is known to cause system
instability issues during option rom execution. Proceeding anyway since user
specified romfile\n",
- vdev->vbasedev.name);
+ warn_report("Device at %s is known to cause system instability"
+ " issues during option rom execution",
+ vdev->vbasedev.name);
+ error_printf("Proceeding anyway since user specified romfile\n");
}
return;
}
@@ -973,11 +975,16 @@ static void vfio_pci_size_rom(VFIOPCIDevice *vdev)
if (vfio_blacklist_opt_rom(vdev)) {
if (dev->opts && qemu_opt_get(dev->opts, "rombar")) {
- error_printf("Warning : Device at %s is known to cause system
instability issues during option rom execution. Proceeding anyway since user
specified non zero value for rombar\n",
- vdev->vbasedev.name);
+ warn_report("Device at %s is known to cause system instability"
+ " issues during option rom execution",
+ vdev->vbasedev.name);
+ error_printf("Proceeding anyway since user specified"
+ " non zero value for rombar\n");
} else {
- error_printf("Warning : Rom loading for device at %s has been
disabled due to system instability issues. Specify rombar=1 or romfile to
force\n",
- vdev->vbasedev.name);
+ warn_report("Rom loading for device at %s has been disabled"
+ " due to system instability issues",
+ vdev->vbasedev.name);
+ error_printf("Specify rombar=1 or romfile to force\n");
return;
}
}
--
2.17.2
- [Qemu-devel] [PATCH v2 00/15] Clean up use of error_printf(), Markus Armbruster, 2019/04/11
- [Qemu-devel] [PATCH v2 04/15] loader-fit: Wean off error_printf(), Markus Armbruster, 2019/04/11
- [Qemu-devel] [PATCH v2 09/15] s390x/kvm: Report warnings with warn_report(), not error_printf(), Markus Armbruster, 2019/04/11
- [Qemu-devel] [PATCH v2 05/15] mips/boston: Report errors with error_report(), not error_printf(), Markus Armbruster, 2019/04/11
- [Qemu-devel] [PATCH v2 11/15] monitor error: Make printf()-like functions return a value, Markus Armbruster, 2019/04/11
- [Qemu-devel] [PATCH v2 10/15] vl: Make -machine $TYPE, help and -accel help print to stdout, Markus Armbruster, 2019/04/11
- [Qemu-devel] [PATCH v2 01/15] qemu-img: Use error_vreport() in error_exit(), Markus Armbruster, 2019/04/11
- [Qemu-devel] [PATCH v2 08/15] vfio: Report warnings with warn_report(), not error_printf(),
Markus Armbruster <=
- [Qemu-devel] [PATCH v2 02/15] block/ssh: Do not report read/write/flush errors to the user, Markus Armbruster, 2019/04/11
- [Qemu-devel] [PATCH v2 06/15] pci: Report fatal errors with error_report(), not error_printf(), Markus Armbruster, 2019/04/11
- [Qemu-devel] [PATCH v2 03/15] char-pty: Drop "char device redirected to" message, Markus Armbruster, 2019/04/11
- Re: [Qemu-devel] [PATCH v2 03/15] char-pty: Drop "char device redirected to" message, Peter Krempa, 2019/04/11
- [Qemu-devel] [PATCH v2 14/15] char: Make -chardev help print to stdout, Markus Armbruster, 2019/04/11
- [Qemu-devel] [PATCH v2 12/15] qemu-print: New qemu_printf(), qemu_vprintf() etc., Markus Armbruster, 2019/04/11
- [Qemu-devel] [PATCH v2 07/15] hpet: Report warnings with warn_report(), not error_printf(), Markus Armbruster, 2019/04/11