Re: [Qemu-devel] [PATCH] set_bit() function added to the source code of uncategorized devices and categorizes have been assigne to them.

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH] set_bit() function added to the source code of 
uncategorized devices and categorizes have been assigne to them.
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
   10546e0..90fb864  master     -> master
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
52c8ae5 set_bit() function added to the source code of uncategorized devices 
and categorizes have been assigne to them.

=== OUTPUT BEGIN ===
ERROR: space required after Signed-off-by:
#9: 
    Signed-off-by:SohailAlvi <address@hidden>

ERROR: trailing whitespace
#29: FILE: hw/block/xen-block.c:628:
+    XenBlockDeviceClass *blockdev_class = XEN_BLOCK_DEVICE_CLASS(class);    $

ERROR: trailing whitespace
#45: FILE: hw/dma/i82374.c:147:
+    set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories);    $

ERROR: trailing whitespace
#170: FILE: hw/mem/nvdimm.c:200:
+    set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);    $

total: 4 errors, 0 warnings, 119 lines checked

Commit 52c8ae56e04d (set_bit() function added to the source code of 
uncategorized devices and categorizes have been assigne to them.) has style 
problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden