[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/8] migration: Fix migrate_set_parameter
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/8] migration: Fix migrate_set_parameter |
Date: |
Fri, 5 Apr 2019 15:32:04 +0100 |
User-agent: |
Mutt/1.11.4 (2019-03-13) |
* Juan Quintela (address@hidden) wrote:
> Otherwise we are setting err twice, what is wrong and causes an abort.
>
> Signed-off-by: Juan Quintela <address@hidden>
Queued just this one.
> ---
> hmp.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/hmp.c b/hmp.c
> index 92941142af..8eec768088 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -1825,8 +1825,10 @@ void hmp_migrate_set_parameter(Monitor *mon, const
> QDict *qdict)
> case MIGRATION_PARAMETER_XBZRLE_CACHE_SIZE:
> p->has_xbzrle_cache_size = true;
> visit_type_size(v, param, &cache_size, &err);
> - if (err || cache_size > INT64_MAX
> - || (size_t)cache_size != cache_size) {
> + if (err) {
> + break;
> + }
> + if (cache_size > INT64_MAX || (size_t)cache_size != cache_size) {
> error_setg(&err, "Invalid size %s", valuestr);
> break;
> }
> --
> 2.20.1
>
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-devel] [PATCH v2 0/8] WIP: Multifd compression support, Juan Quintela, 2019/04/03
- [Qemu-devel] [PATCH v2 3/8] migration-test: rename parameter to parameter_int, Juan Quintela, 2019/04/03
- [Qemu-devel] [PATCH v2 8/8] multifd: rest of zlib compression (WIP), Juan Quintela, 2019/04/03
- [Qemu-devel] [PATCH v2 1/8] migration: Fix migrate_set_parameter, Juan Quintela, 2019/04/03
- [Qemu-devel] [PATCH v2 2/8] migration: fix multifd_recv event typo, Juan Quintela, 2019/04/03
- [Qemu-devel] [PATCH v2 5/8] migration-test: introduce functions to handle string parameters, Juan Quintela, 2019/04/03
- [Qemu-devel] [PATCH v2 7/8] multifd: Add zlib compression support, Juan Quintela, 2019/04/03
- [Qemu-devel] [PATCH v2 4/8] tests: Add migration multifd test, Juan Quintela, 2019/04/03
- [Qemu-devel] [PATCH v2 6/8] migration: Add multifd-compress parameter, Juan Quintela, 2019/04/03
- Re: [Qemu-devel] [PATCH v2 0/8] WIP: Multifd compression support, no-reply, 2019/04/03