[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-4.0] roms: Allow the EFIROM variable to be o
From: |
Olaf Hering |
Subject: |
Re: [Qemu-devel] [PATCH for-4.0] roms: Allow the EFIROM variable to be overridden |
Date: |
Fri, 5 Apr 2019 15:04:38 +0200 |
Am Fri, 5 Apr 2019 14:59:16 +0200
schrieb Philippe Mathieu-Daudé <address@hidden>:
> On 4/5/19 2:09 PM, Olaf Hering wrote:
> > Am Fri, 5 Apr 2019 13:55:29 +0200
> > schrieb Philippe Mathieu-Daudé <address@hidden>:
> >
> >> +EFIROM ?= edk2/BaseTools/Source/C/bin/EfiRom
> >
> > This name is too generic and will conflict with ipxe.git if any of "bios
> > seavgabios pxerom" is used for 'make -C roms'.
>
> This is similar to commit c9d18c1c150c84e where you said "it used to
> work", what is the difference?
Before there was no need to pass EFIROM= to make, so ipxe.git was happy.
Now it is required, and ipxe.git gets an unexpected value.
> IPXE override the EFIROM variable, so there is no change there.
For me ipxe tries to rm $(type -P EfiRom). Let me double check.
> How can I trigger a SUSE package build with this patch?
Not so easy without a VM.
Olaf
pgpofRhYgkSnf.pgp
Description: Digitale Signatur von OpenPGP