[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] edk2 fails to compile in v4.0.0-rc2
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] edk2 fails to compile in v4.0.0-rc2 |
Date: |
Fri, 5 Apr 2019 13:29:44 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 4/5/19 1:16 PM, Olaf Hering wrote:
> Am Fri, 5 Apr 2019 12:59:18 +0200
> schrieb Olaf Hering <address@hidden>:
>
>> This used to work still in January with
>> c9d18c1c150c84e7a976df989ad04ddf01083f46.
>
> It is not possible to just override EFIROM=$(type -P EfiRom) because this
> variable is also used by ipxe.git.
Yes, lets got back with the overridable form previous to f590a812c210:
-- >8 --
diff --git a/roms/Makefile b/roms/Makefile
index 78d5dd18c30..fc501a6c30c 100644
--- a/roms/Makefile
+++ b/roms/Makefile
@@ -49,3 +49,3 @@ SEABIOS_EXTRAVERSION="-prebuilt.qemu.org"
#
-EFIROM = edk2/BaseTools/Source/C/bin/EfiRom
+EFIROM ?= edk2/BaseTools/Source/C/bin/EfiRom
---
I'll submit that patch.
Thanks,
Phil.
signature.asc
Description: OpenPGP digital signature