[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qom: use object_new_with_type in object_new_wit
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH] qom: use object_new_with_type in object_new_with_propv |
Date: |
Tue, 02 Apr 2019 08:27:36 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Stefano Garzarella <address@hidden> writes:
> On Mon, Mar 11, 2019 at 04:32:34PM +0800, Wei Yang wrote:
>> Function object_new_with_propv already get the Type of the object, so we
>> could leverage object_new_with_type here.
>>
>> [make check test pass]
>>
>> Signed-off-by: Wei Yang <address@hidden>
>> ---
>> qom/object.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> LGTM. Just a note for future patches:
> I think that info like "[make check test pass]" should go after the
> three dashes to avoid to store it in the commit message.
Yes. Whoever applies should delete this line.
> Reviewed-by: Stefano Garzarella <address@hidden>
Cc: qemu-trivial for merging.
- Re: [Qemu-devel] [PATCH] qom: use object_new_with_type in object_new_with_propv,
Markus Armbruster <=